Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfork EventQueueProcessor.cpp and TimerManager.cpp #13516

Open
jonthysell opened this issue Jul 30, 2024 · 1 comment
Open

Unfork EventQueueProcessor.cpp and TimerManager.cpp #13516

jonthysell opened this issue Jul 30, 2024 · 1 comment
Assignees
@jonthysell
Labels
bug Integration Follow-up Upstream
Milestone
Next

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Jul 30, 2024 •
edited
Loading

Problem Description

Getting C4715 not all control paths return a value warnings turning into errors due to new switches with enums that don't have a default return value.

Link to the integration where the error originated

#13508

Link to commit

facebook/react-native@404f323

facebook/react-native@a8a76f9

Forked files

  1. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\renderer\core\EventQueueProcessor.cpp
  2. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\react\runtime\TimerManager.cpp

Upstream PR

facebook/react-native#45827

Build Configuration

None
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 30, 2024
jonthysell added a commit to jonthysell/react-native that referenced this issue Jul 30, 2024
@jonthysell
Fix "C4715 not all control paths return a value" warning in MSVC
ecf152c 
See microsoft/react-native-windows#13516
@jonthysell jonthysell mentioned this issue Jul 30, 2024
Closed
@jonthysell jonthysell self-assigned this Aug 1, 2024
@jonthysell jonthysell added this to the Next milestone Aug 1, 2024
@jonthysell jonthysell removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 2, 2024
@jonthysell jonthysell added bug and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Aug 2, 2024
@Yajur-Grover Yajur-Grover mentioned this issue Aug 7, 2024
Merged
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Aug 12, 2024
@jonthysell @facebook-github-bot
Fix "C4715 not all control paths return a value" warning in MSVC (#45827
c30e35f 
)

Summary:
When integrating react-native into react-native-windows, we got the following build warning (which we treat as an error) when building ReactCommon: `C4715 not all control paths return a value`

This PR adds defaults to the switches to make sure every path returns a value.

See microsoft/react-native-windows#13516

## Changelog:

[GENERAL] [FIXED] Fix "C4715 not all control paths return a value" warning in MSVC when building ReactCommon

Pull Request resolved: #45827

Test Plan: The switches are checking enums this code should never be hit unless new enum values are added.

Reviewed By: robhogan

Differential Revision: D61103286

Pulled By: NickGerleman

fbshipit-source-id: 2028cb60e0b438b9ac17a828f5e1b690052a0bec
@jonthysell
Copy link
Contributor Author

This was merged upstream on Aug 12th, so we should be able to unfork when we catch up to that build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonthysell jonthysell

Labels
bug Integration Follow-up Upstream
Projects
None yet
Milestone
Next
Development

No branches or pull requests
1 participant
@jonthysell