Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up public surface of ReactNative library #22

Closed
rozele opened this issue Dec 22, 2015 · 2 comments
Closed

Clean up public surface of ReactNative library #22

rozele opened this issue Dec 22, 2015 · 2 comments

Comments

@rozele
Copy link
Collaborator

rozele commented Dec 22, 2015

This includes sealing classes as appropriate, and making anything that does not need to be public internal.

@rozele
Copy link
Collaborator Author

rozele commented Aug 30, 2016

Let's have another pass over things like ReactInstanceManager and ReactPage. Make things fully async where they should be. Having async void bit us on a couple unit tests and I can see it doing the same to power users who want to set up their own ReactInstanceManager embedded within a UWP app.

@rozele
Copy link
Collaborator Author

rozele commented Jul 23, 2018

Should be done as part of the work to refactor into a collection of .NET Standard libraries, but this issue is too large to be actionable.

@rozele rozele closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant