feat(Portable): Migrate NetInfo module #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
reviewed
Oct 12, 2016
| @@ -326,7 +326,7 @@ public void HandleException(Exception exception) | |||
| /// <remarks> | |||
| /// This method should be called exactly once. | |||
| /// </remarks> | |||
| internal void InitializeWithInstance(IReactInstance instance) | |||
| public void InitializeWithInstance(IReactInstance instance) | |||
There was a problem hiding this comment.
public [](start = 8, length = 6)
I don't know why this was internal in the first place, but maybe just keep it internal. There's a very old GH issue to revisit the public API surface: #22
There was a problem hiding this comment.
You can add an InternalsVisibleTo attribute to the AssemblyInfo.cs file for ReactNative.Net46 for the time being.
In reply to: 83104991 [](ancestors = 83104991)
There was a problem hiding this comment.
We're using this in the tests and without it being public VS complains. Not sure what black magic occurs in the UWP tests that allows it to get around this requirement but on that side it doesn't seem to care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @GantMan @rozele @matthargett