Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <react-native-reanimated> #4151

Closed
1 task
robertev opened this issue Feb 20, 2020 · 12 comments · Fixed by software-mansion/react-native-reanimated#1000
Closed
1 task

Support <react-native-reanimated> #4151

robertev opened this issue Feb 20, 2020 · 12 comments · Fixed by software-mansion/react-native-reanimated#1000
Assignees
Labels
Extensions Tracks issues against community modules and extensions Partner: AppConsult AppConsult managed customers Partner: Stream (label may be applied by bot based on author)
Milestone

Comments

@robertev
Copy link

robertev commented Feb 20, 2020

Support react-native-reanimated on RNW vNext

Basic Info

Overview of Required Functionality

React Native's Animated library reimplemented
PureJS - no

Similar to Gesture Handler, this is dependency of React Native Navigation. I assume it animates scene transitions during navigation. Perhaps Windows implementation can stub out empty behaviors for an initial version?

@robertev robertev added Extensions Tracks issues against community modules and extensions vnext labels Feb 20, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 20, 2020
@harinikmsft harinikmsft added this to the MVP+ (vNext M5) milestone Feb 20, 2020
@harinikmsft harinikmsft added the Partner: AppConsult AppConsult managed customers label Feb 20, 2020
@harinikmsft harinikmsft modified the milestones: MVP+ (vNext M5), Backlog Feb 20, 2020
@harinikmsft harinikmsft removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 20, 2020
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@namrog84
Copy link
Contributor

namrog84 commented Apr 9, 2020

+1 as this is still causing us issues (indirectly thru react native navigation)

@harinikmsft harinikmsft added the Partner: Stream (label may be applied by bot based on author) label Apr 14, 2020
@harinikmsft
Copy link
Contributor

This is needed for #3884

@kmagiera
Copy link

This issue has recently been brought to my attention. As a creator and maintainer of gesture-handler and reanimated I'd be happy to discuss how me and team can help push this forward.

An important aspect is that soon we are going to be releasing next version of reanimated that will primarily be written in c++. I believe this should make it more approachable to port to other platforms.

@kaiguo
Copy link
Contributor

kaiguo commented May 19, 2020

An important aspect is that soon we are going to be releasing next version of reanimated that will primarily be written in c++. I believe this should make it more approachable to port to other platforms.

Hi @kmagiera, thanks for reaching out!

Do you have an ETA of the next release (c++ version)? Can you point me to the branch if it's available? I was planning to map existing Android/iOS implementation to Windows c++/winrt, how hard is it to migrate existing implementation to the next c++ release?

Tring to figure out whether we should start the work now based on the current js implementation or wait for the next c++ release first.

@kmagiera
Copy link

We should have the first alpha release of the c++ implementation out in the next two weeks. Can't share too many details just yet on that though.

On another note, I noticed that this got marked as priority because of react-navigation which supposedly depends on reanimated. However this is no longer true as of react-navigation v5 where despite reanimated being listed among indirect dependencies the library is not used.

@namrog84
Copy link
Contributor

namrog84 commented May 19, 2020

You say it's not being used, but https://github.com/react-navigation/react-navigation master branch says its for v5

but I can still see a 2 places where react-native-reanimated is being used in the drawer component?

@kmagiera
Copy link

Ah, yes, I definitely missed that. It is used by some navigation packages (could be only drawer) but not by the core. On top of that even when new reanimated is released it will take some time for components such as drawer to migrate to new version that relies on the c++ core.

@kaiguo
Copy link
Contributor

kaiguo commented May 20, 2020

@namrog84 are we using drawer in our apps? If not I think we should be unblocked?

If we do use drawer sounds like we'll need to add Windows reanimated based on current implementation since it'll take some time for other components to migrate to the new version as @kmagiera mentioned.

@namrog84
Copy link
Contributor

Yes, we use drawer.

We currently use "react-navigation", "react-navigation-drawer", "react-navigation-hooks", "react-navigation-stack", and "react-navigation-tabs"

@kaiguo
Copy link
Contributor

kaiguo commented Jun 2, 2020

@robertev @namrog84 what react-native-windows version are you guys on?

I think I'll need @vmoroz's notification service above to implement this module. Currently that service is targeting 0.63(+) which means this reanimated module will only be available on 0.63+ as well. Will that work for you guys? We are trying to decide whether we should backport the notification service to 62. Thanks!

@namrog84
Copy link
Contributor

namrog84 commented Jun 2, 2020

In process of moving onto RN 62 right now. Then further progress will be de-prioritized.

However, waiting until 63+ is totally fine for us. As some temporary reprioritzation is happening for us for next few months.

@kaiguo
Copy link
Contributor

kaiguo commented Jun 4, 2020

Hi @kmagiera, I saw you submitted the cpp implementation, any idea when will drawer be migrated to the new version?

I guess another options is (I haven't dig into the drawer code yet), can we use the built-in animated instead of reanimated in drawer? If that's possible I'm happy to help making the change, since our end goal is to unblock the usage of react-navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extensions Tracks issues against community modules and extensions Partner: AppConsult AppConsult managed customers Partner: Stream (label may be applied by bot based on author)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants