Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows and macOS platforms #1000

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Jul 20, 2020

Description

Adding Windows and macOS supports.

Close microsoft/react-native-windows#4151.
Unblock microsoft/react-native-windows#3884.

Changes

Following the web path to add Windows and macOS stubs. This helps us unblock the usages of react-navigation.

@jakub-gonet
Copy link
Member

Have you tested those changes on examples from the Example app?

@jakub-gonet jakub-gonet self-assigned this Jul 21, 2020
@kaiguo
Copy link
Contributor Author

kaiguo commented Jul 21, 2020

@jakub-gonet Many of the examples use gesture, Windows and macOS don't have react-native-gesture-handler support yet. Also the example app is targeting react-native 0.63, react-native-windows is still on 0.62 so I wasn't able to just add a Windows example app.

I did test some of the pages that don't require gesture in my separate test app, like imperative, progressBar and rotations, they worked fine. We are trying to unblock react-navigation so I tested it in drawer navigation as well, here's a gif I captured earlier : )

@jakub-gonet
Copy link
Member

Thanks for testing it.

Even if it's working partially it's better than nothing I guess

@jakub-gonet
Copy link
Member

BTW, congrats on such nice PR number 😄

@jakub-gonet jakub-gonet changed the title Add Windows and macOS supports Support Windows and macOS platforms Jul 21, 2020
@jakub-gonet jakub-gonet merged commit 265d7cd into software-mansion:master Jul 21, 2020
@kaiguo
Copy link
Contributor Author

kaiguo commented Jul 21, 2020

@jakub-gonet one more question, can we backport this to 1.x? react-navigation is still on reanimated1, we'd have to wait them to migrate to 2.x to add windows support otherwise.

@kaiguo kaiguo deleted the add-windows-mac branch July 21, 2020 19:01
@jakub-gonet
Copy link
Member

Sure, could you prepare the same PR against v1 branch? I want to release 1.10.0 tomorrow.

@kaiguo
Copy link
Contributor Author

kaiguo commented Jul 21, 2020

Sure, could you prepare the same PR against v1 branch? I want to release 1.10.0 tomorrow.

Yep, will do it later today. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support <react-native-reanimated>
3 participants