-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows and macOS platforms #1000
Conversation
Have you tested those changes on examples from the Example app? |
@jakub-gonet Many of the examples use gesture, Windows and macOS don't have react-native-gesture-handler support yet. Also the example app is targeting react-native 0.63, react-native-windows is still on 0.62 so I wasn't able to just add a Windows example app. I did test some of the pages that don't require gesture in my separate test app, like imperative, progressBar and rotations, they worked fine. We are trying to unblock react-navigation so I tested it in drawer navigation as well, here's a gif I captured earlier : ) |
Thanks for testing it. Even if it's working partially it's better than nothing I guess |
BTW, congrats on such nice PR number 😄 |
@jakub-gonet one more question, can we backport this to 1.x? react-navigation is still on reanimated1, we'd have to wait them to migrate to 2.x to add windows support otherwise. |
Sure, could you prepare the same PR against v1 branch? I want to release 1.10.0 tomorrow. |
Yep, will do it later today. Thanks! |
Description
Adding Windows and macOS supports.
Close microsoft/react-native-windows#4151.
Unblock microsoft/react-native-windows#3884.
Changes
Following the web path to add Windows and macOS stubs. This helps us unblock the usages of react-navigation.