Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete IRootView? #847

Closed
rigdern opened this issue Nov 1, 2016 · 0 comments
Closed

Delete IRootView? #847

rigdern opened this issue Nov 1, 2016 · 0 comments

Comments

@rigdern
Copy link
Contributor

rigdern commented Nov 1, 2016 •
edited
Loading

It looks like IRootView isn't referenced by any code except some tests. Should it be deleted?

MeasureAssertions also looks unused.
rozele added a commit that referenced this issue Nov 1, 2016
@rozele
chore(ReactWindows): Cleanup dead code
7e58a60 
Removing IRootView and MeasureAssertions which are no longer in use.

Fixes #847
@rozele rozele mentioned this issue Nov 1, 2016
Closed
@rozele rozele self-assigned this Nov 1, 2016
@rozele rozele mentioned this issue Nov 1, 2016
Merged
rozele added a commit that referenced this issue Nov 1, 2016
@rozele
chore(ReactWindows): Cleanup dead code (#852)
99624a7 
Removing IRootView and MeasureAssertions which are no longer in use.

Fixes #847
rozele added a commit that referenced this issue Nov 10, 2016
@rozele
chore(ReactWindows): Cleanup dead code (#852)
3476dd2 
Removing IRootView and MeasureAssertions which are no longer in use.

Fixes #847
@snyk-bot snyk-bot mentioned this issue Jan 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rigdern @rozele