[Win32] Reduce usage of long paths in assets which can cause long path issues #11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
acoates-ms
force-pushed
the
saveAssetPluginWin32
branch
from
1cefb73 to
4cf790e
Compare
…eact-native-windows into saveAssetPluginWin32
vmoroz
approved these changes
Aug 10, 2023
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 10, 2023
…h issues (microsoft#11839) * Add saveAssetPlugin to fix long path assets * Change files * comment * add back compat * fix * turn off win32 assetPlugin for now * fix * fix * fix * Change files * fix
acoates-ms
added a commit
that referenced
this pull request
Aug 11, 2023
* [Win32] Reduce usage of long paths in assets which can cause long path issues (#11839) * Add saveAssetPlugin to fix long path assets * Change files * comment * add back compat * fix * turn off win32 assetPlugin for now * fix * fix * fix * Change files * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code that would go with react-native-community/cli#2002 to implement a
saveAssetPluginfor rn-win32. This allows rn-win32 to customize the layout of the asset files on disc, in particular shortening longer paths to avoid hitting max path length on systems that do not have long path support enabled.Why
Issues when installing / loading images with long paths - which is especially common when loading images from npm packages and using pnpm as the package manager.
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Optional: Describe the tests that you ran locally to verify your changes.
Microsoft Reviewers: codeflow:open?pullrequest=#11839