Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when blur command received on node without XamlRoot #12051

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Fix bug when blur command received on node without XamlRoot #12051

merged 2 commits into from
Aug 29, 2023

Commits on Aug 21, 2023

  1. Fix bug when blur command received on node without XamlRoot 

    We are seeing crashes on quit when the blur command is called roughly
around the same time that the React instance is being shut down. It's
likely because the result of tryGetXamlRoot is null.

This change falls back on the GetFocusedElement() overload without any
parameters if the XamlRoot is null, as supplying a null parameter will
result in a NPE.
    @rozele
    rozele committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    1a9d2a4 View commit details
    Browse the repository at this point in the history

  2. Change files

    @rozele
    rozele committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3d2b48f View commit details
    Browse the repository at this point in the history