-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VisitAllPages Test to E2E Test App on Fabric #12052
Conversation
@@ -184,7 +184,7 @@ jobs: | |||
parameters: | |||
buildEnvironment: ${{ parameters.BuildEnvironment }} | |||
certificateName: reactUWPTestAppEncodedKey | |||
buildConfiguration: Debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does debug not work? I'd be curious on what the issue with debug is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Debug we would need to add a launch for Metro. This matches the behavior of the test app on Paper which runs in Release for automated tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? I suppose better than not running them. Its possible to run debug against a prebuilt bundle just as we do in release. But at least getting to where we are in paper is a good thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can look into that!
if (!result) { | ||
console.warn( | ||
example, | ||
'Page was skipped due to inconsistent WebDriverIO behavior. Please verify page can load locally or rerun this test.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there specific pages that are sometimes taking too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code can be removed now. Moving to running the automated tests in Release instead of Debug resolved this finnicky behavior.
Description
Type of Change
Why
Increase automated validation in React Native Windows.
#11422
What
Adds visitallpages test to e2e test app for fabric. First test which interacts with the app and renders different app pages.
Microsoft Reviewers: Open in CodeFlow