Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VisitAllPages Test to E2E Test App on Fabric #12052

Merged
merged 27 commits into from
Aug 25, 2023

Conversation

chiaramooney
Copy link
Contributor

@chiaramooney chiaramooney commented Aug 22, 2023

Description

Type of Change

  • Testing

Why

Increase automated validation in React Native Windows.

#11422

What

Adds visitallpages test to e2e test app for fabric. First test which interacts with the app and renders different app pages.

Microsoft Reviewers: Open in CodeFlow

@chiaramooney chiaramooney requested a review from a team as a code owner August 22, 2023 00:00
@chiaramooney chiaramooney requested a review from a team as a code owner August 23, 2023 00:37
@@ -184,7 +184,7 @@ jobs:
parameters:
buildEnvironment: ${{ parameters.BuildEnvironment }}
certificateName: reactUWPTestAppEncodedKey
buildConfiguration: Debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does debug not work? I'd be curious on what the issue with debug is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Debug we would need to add a launch for Metro. This matches the behavior of the test app on Paper which runs in Release for automated tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I suppose better than not running them. Its possible to run debug against a prebuilt bundle just as we do in release. But at least getting to where we are in paper is a good thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look into that!

if (!result) {
console.warn(
example,
'Page was skipped due to inconsistent WebDriverIO behavior. Please verify page can load locally or rerun this test.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there specific pages that are sometimes taking too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code can be removed now. Moving to running the automated tests in Release instead of Debug resolved this finnicky behavior.

@chiaramooney chiaramooney merged commit c0b68f3 into microsoft:main Aug 25, 2023
@chiaramooney chiaramooney deleted the cm-visit-test branch August 25, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants