Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactContext should have a weak ref on the PropertyBag #12340

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Nov 1, 2023

Description

ReactContext is supposed to be a weak reference to the inner react instance. But it is currently also holding a reference onto the ReactPropertyBag, which means that ReactContext is keeping alive a lot more than it should be.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner November 1, 2023 20:39
@acoates-ms acoates-ms enabled auto-merge (squash) November 1, 2023 20:50
@acoates-ms acoates-ms merged commit 325195c into microsoft:main Nov 1, 2023
43 checks passed
@acoates-ms acoates-ms deleted the contextwkref branch November 13, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants