Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LayoutAnimation): Adds scaleXY support for LayoutAnimation #1235

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

rozele
Copy link
Collaborator

@rozele rozele commented Jul 28, 2017

Previously, only update and opacity animations were supported in LayoutAnimation. This change uses ScaleTransform to support scaleXY LayoutAnimation.

Fixes #217

@msftclas
Copy link

@rozele,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Previously, only update and opacity animations were supported in LayoutAnimation. This change uses ScaleTransform to support scaleXY LayoutAnimation.

Fixes microsoft#217
@codecov-io
Copy link

Codecov Report

Merging #1235 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
- Coverage   31.79%   31.76%   -0.04%     
==========================================
  Files         258      258              
  Lines       18667    18685      +18     
  Branches     1578     1580       +2     
==========================================
- Hits         5936     5935       -1     
- Misses      12574    12592      +18     
- Partials      157      158       +1
Impacted Files Coverage Δ
...d/UIManager/LayoutAnimation/BaseLayoutAnimation.cs 0% <0%> (ø) ⬆️
...tNative.Shared/Modules/Network/NetworkingModule.cs 65.57% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3e7e4...e997275. Read the comment docs.

@rozele rozele merged commit bb95091 into microsoft:master Jul 28, 2017
@rozele rozele deleted the issue217 branch July 28, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants