[Fabric] Add onSubmitEditing and clearTextOnSubmit #12746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaKapos
commented
Feb 16, 2024
| @@ -786,6 +791,11 @@ void WindowsTextInputComponentView::OnKeyUp( | |||
| lParam |= 0x40000000; // bit 30 | |||
| lParam |= 0x80000000; // bit 31 always 1 for WM_KEYUP | |||
|
|
|||
| // check to see if shift is released | |||
| if (args.Key() == winrt::Windows::System::VirtualKey::Shift) { | |||
There was a problem hiding this comment.
this works but is there a better way to know if the shift key is pressed down? Didn't want to add the rest of the keys until I got confirmation on this :)
There was a problem hiding this comment.
You shouldn't try to keep track of the key state in WindowsTextInputComponentView. Instead you should query the state as needed.
The KeyboardSource object has a method to get the key state of a key, you should pass that to the ShouldSubmit function.
TatianaKapos
changed the title
jonthysell
approved these changes
Feb 21, 2024
This was referenced Feb 21, 2024
233 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds onSumbitEditing and clearTextOnSubmit to TextInput
Type of Change
Why
TextInput parity
What
Adds onSumbitEditing event to TextInput and keeps track of if the shift key is pressed.
Screenshots
Playground-composition_QPMHOlSOIT.mp4
Testing
tested locally
Changelog
no
Microsoft Reviewers: Open in CodeFlow