Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up LongLivedObjectCollection created by RN Windows #12934

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rozele
Copy link
Collaborator

@rozele rozele commented Apr 9, 2024

Description

Type of Change

Erase all that don't apply.

  • Bug fix (non-breaking change which fixes an issue)

Why

Our app has some cross platform JSI modules that use the default LongLivedObjectCollection, which does not get cleaned up by react-native-windows. Moving to the intrinsically per-VM LongLivedObjectCollection helps :).

Resolves [Add Relevant Issue Here]

What

Eliminates the LongLivedObjectCollection created by TurboModulesProvider.

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

@rozele rozele requested a review from a team as a code owner April 9, 2024 17:17
React Native now intrinsically supports per-VM
LongLivedObjectCollections, so the additional behavior in Windows is
redundant.
@chrisglein
Copy link
Member

@vmoroz Can you review this, since you were dealing with something similar a short time ago?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants