[Telemetry] Migration from AppInsights to 1DS #13493
Conversation
danielayala94
changed the title
packages/@react-native-windows/telemetry/src/e2etest/telemetry.test.ts
Outdated
Show resolved
Hide resolved
packages/@react-native-windows/telemetry/src/utils/errorUtils.ts
Outdated
Show resolved
Hide resolved
packages/@react-native-windows/telemetry/src/utils/errorUtils.ts
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
packages/@react-native-windows/telemetry/src/e2etest/telemetry.test.ts
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
| */ | ||
| export async function fullBuildInfo(): Promise<string> { | ||
| try { | ||
| let regCommand = `${process.env.windir}\\System32\\reg.exe query ${DeviceIdBuildPath} /v ${DeviceIdBuildKey}`; |
There was a problem hiding this comment.
Can you refactor the command part of this into a registry-key getting helper that can be shared with deviceId()?
| @@ -67,12 +67,6 @@ test('deviceDiskFreeSpace() is valid', () => { | |||
| expect(value).toBeGreaterThanOrEqual(0); | |||
| }); | |||
|
|
|||
| test('sampleRate() is within valid range', () => { | |||
There was a problem hiding this comment.
Does the telemetry automatically contain the sample rate?
| * @returns A string containing the Windows build name, number and architecture. | ||
| * e.g. 19569.1000.amd64fre.rs_prerelease.200214-1419 | ||
| */ | ||
| export async function fullBuildInfo(): Promise<string> { |
There was a problem hiding this comment.
Can you make sure to add a test for this?
| @@ -63,7 +89,9 @@ export function nodeArchitecture(): string { | |||
| * @returns The device platform. | |||
| */ | |||
| export function devicePlatform(): string { | |||
| return platform(); | |||
| const os = platform(); | |||
There was a problem hiding this comment.
Can we keep this function behavior as-is and rename it to nodePlatform()?
I want to make sure we record what node's platform() call returns (since it's our of our control and may be relevant to debugging issues) and would rather stick it in our own common field rather than munge it to fit into the PartA deviceClass.
Then we should then have a different method to get the correct value for deviceClass (which may take the output from nodePlatform and transform it to Windows for windows PCs, but we should make sure we also put the correct expected values for mac/linux).
Description
Type of Change
New feature.
Why
Enable posting telemetry data to have information that will allow us to take informed decisions on what areas of RNW we should focus, identify customer pains, RNW usage, etc.
Resolves #10473
Resolves #10142
Resolves #10141
What
Testing
All E2E tests on telemetry.test.ts are passing after the refactoring.
All other telemetry tests are passing after the refactoring as well.
Changelog
Yes
Microsoft Reviewers: Open in CodeFlow