Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Testing for accessibilityValue and Implement IValueProvider conditionally #13544

Merged
merged 19 commits into from
Aug 20, 2024
Merged

Add Testing for accessibilityValue and Implement IValueProvider conditionally #13544

merged 19 commits into from
Aug 20, 2024

Conversation

chiaramooney
Copy link
Contributor

@chiaramooney chiaramooney commented Aug 6, 2024 •
edited
Loading

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Adjust support for accessibilityValue and IValueProvider to complete implementation of these features.

#13328
#12510

What

  • Adjust IValueProvider to only be implemented conditionally. Only certain controls should implement IValueProvider per UIA documentation
  • Add tests for accessibilityValue. Add ValuePattern.Value data to accessibility tree dumps.
  • Fix type with getAccessibilityValue() API, had an extra 'c' in the name

Testing

Added tests to E2E testing

Changelog

Should this change be included in the release notes: No

Microsoft Reviewers: Open in CodeFlow

@chiaramooney chiaramooney requested a review from a team as a code owner August 6, 2024 23:25
@jonthysell jonthysell added Area: Accessibility Area: Fabric Support Facebook Fabric labels Aug 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Aug 13, 2024
@chiaramooney chiaramooney merged commit b9aed0e into microsoft:main Aug 20, 2024
55 checks passed
@chiaramooney chiaramooney deleted the cm-value-provider branch September 4, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@TatianaKapos TatianaKapos TatianaKapos approved these changes

Assignees
No one assigned
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiaramooney @acoates-ms @TatianaKapos @jonthysell