Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce StatusBarManger module aligns with Spec #13556

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Aug 9, 2024

Description

The empty implementation of StatusBarManager here does not run when web debugging, as empty modules are ignored by the web debugging runtime. This causes a StatusBarManager is missing error when web debugging, which causes the instance to not load.

This will fix #13550 when ported to 0.75

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner August 9, 2024 20:49
@microsoft-github-policy-service microsoft-github-policy-service bot added Area: Debug Infrastructure Area: Paper Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper labels Aug 9, 2024
@acoates-ms acoates-ms merged commit b0285c8 into microsoft:main Aug 13, 2024
55 checks passed
@acoates-ms acoates-ms deleted the statusbarmanager branch August 13, 2024 14:36
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 13, 2024
TatianaKapos added a commit to TatianaKapos/react-native-windows that referenced this pull request Aug 13, 2024
TatianaKapos added a commit to TatianaKapos/react-native-windows that referenced this pull request Aug 13, 2024
TatianaKapos added a commit that referenced this pull request Aug 14, 2024
#13568)

* backport Enforce StatusBarManger module aligns with Spec #13556

* Change files
TatianaKapos added a commit that referenced this pull request Aug 14, 2024
#13569)

* backport Enforce StatusBarManger module aligns with Spec #13556

* Change files
@jonthysell jonthysell added this to the Next milestone Aug 28, 2024
@jonthysell jonthysell removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Debug Infrastructure Area: Paper Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.75] [Web Debugging] Unable to fully debug a new 0.75 app
3 participants