Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.75] Update templates to calculate rnwPath for *.sln files #13612

Merged
merged 1 commit into from
Aug 26, 2024

Commits on Aug 26, 2024

  1. [0.75] Update templates to calculate rnwPath for *.sln files

    This PR backports microsoft#13572 to 0.75.
    
    ## Description
    
    Visual Studio solution files cannot use variables in paths to the various project files, and up until now the paths to RNW projects assumed a simple app repo, and were hardcoded to `..\node_modules\react-native-windows\`.
    
    This PR changes the templates for both new and old architecture projects to instead inject the calculated actual path to the RNW package.
    
    **Note:** Node does not "see" symlinks, only their resolved path. So if you're getting RNW via a symlink (say through yarn link) the sln file will hardcode the resolved path at the time of creation.
    
    ### Type of Change
    - Bug fix (non-breaking change which fixes an issue)
    - New feature (non-breaking change which adds functionality)
    
    ### Why
    Some user feedback has indicated that the hardcoded paths did not work for monorepos which may have multiple packages depending on RNW.
    
    ### What
    See above.
    
    ## Screenshots
    N/A
    
    ## Testing
    Verified that the path is now generated.
    
    ## Changelog
    Should this change be included in the release notes: _yes_
    
    Update templates to calculate rnwPath for *.sln files
    jonthysell committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2c44f36 View commit details
    Browse the repository at this point in the history