[Fabric] Native component codegen #13640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
changed the title
marlenecota
reviewed
Sep 5, 2024
| case 'ImageRequestPrimitive': | ||
| case 'ImageSourcePrimitive': | ||
| case 'PointPrimitive': | ||
| arrayTemplateArg = 'winrt::Microsoft::ReactNative::JSValue'; // TODO - better handling for these types than JSValue |
There was a problem hiding this comment.
do we need tracking issues for these TODOs?
marlenecota
approved these changes
Sep 5, 2024
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Sep 5, 2024
* Prep for native component codegen * format * Change files * Add codegen * handle more types in codegen * Minor cleanup * Change files * Add additional custom handler registration * Move DrawingIsland implementation into shared package * format * Fix component view macros to use member name arg * update package versions * generate a base class - implement commands * snapshots * Move moving light example into rntester * Remove extra 2 on register method * snapshots
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Sep 5, 2024
* Prep for native component codegen * format * Change files * Add codegen * handle more types in codegen * Minor cleanup * Change files * Add additional custom handler registration * Move DrawingIsland implementation into shared package * format * Fix component view macros to use member name arg * update package versions * generate a base class - implement commands * snapshots * Move moving light example into rntester * Remove extra 2 on register method * snapshots
acoates-ms
added a commit
that referenced
this pull request
Sep 6, 2024
* [Fabric] Add Support for the IToggleProvider (#13622) * Add Support for Toggle Provider * Refactor Dump Alg * Change files * Format * Fix Merge Error * Fix Merge Error * [Fabric] Native component codegen (#13640) * Prep for native component codegen * format * Change files * Add codegen * handle more types in codegen * Minor cleanup * Change files * Add additional custom handler registration * Move DrawingIsland implementation into shared package * format * Fix component view macros to use member name arg * update package versions * generate a base class - implement commands * snapshots * Move moving light example into rntester * Remove extra 2 on register method * snapshots
acoates-ms
added a commit
that referenced
this pull request
Sep 6, 2024
* [Fabric] Add Support for the IToggleProvider (#13622) * Add Support for Toggle Provider * Refactor Dump Alg * Change files * Format * Fix Merge Error * Fix Merge Error * [Fabric] Native component codegen (#13640) * Prep for native component codegen * format * Change files * Add codegen * handle more types in codegen * Minor cleanup * Change files * Add additional custom handler registration * Move DrawingIsland implementation into shared package * format * Fix component view macros to use member name arg * update package versions * generate a base class - implement commands * snapshots * Move moving light example into rntester * Remove extra 2 on register method * snapshots * lint:fix --------- Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds codegen for custom native components.
Implements a new custom native component as a sample.
Moved the DrawingIsland custom native component to the new sample package
Microsoft Reviewers: Open in CodeFlow