Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for AccessibilityState:Busy #13952

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

chiaramooney
Copy link
Contributor

@chiaramooney chiaramooney commented Oct 9, 2024

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Add support for AccessibilityState:Busy

Resolves #13327
Resolves #13066
Resolves #13062
Resolves #13058
Resolves #13054
Resolves #13050
Resolves #13046
Resolves #13042
Resolves #13038
Resolves #13034

What

  • When accessibilityState={{busy: true}} is specified, ItemStatus property in UIA should have string "Busy". Otherwise, property will remain unset.

Testing

TODO

Changelog

Should this change be included in the release notes: Yes

Add support for accessibilityState: busy to Fabric.

@chiaramooney chiaramooney requested a review from a team as a code owner October 9, 2024 21:12
@microsoft-github-policy-service microsoft-github-policy-service bot added Area: Accessibility Area: ActivityIndicator Area: Component Views Area: Fabric Support Facebook Fabric Area: Image Area: Modal Area: RefreshControl Area: ScrollView Area: Switch Area: Text Area: TextInput Area: View Area: View Props https://reactnative.dev/docs/view#props Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric labels Oct 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Oct 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Oct 11, 2024
@chiaramooney
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@chiaramooney chiaramooney merged commit 37e15f1 into microsoft:main Oct 14, 2024
59 checks passed
@chiaramooney chiaramooney deleted the state-busy branch October 14, 2024 20:57
acoates-ms pushed a commit to acoates-ms/react-native-windows that referenced this pull request Oct 16, 2024
* Support AccessibilityState: Busy

* Change files

* Add Testing

* Update Snapshots

* Update for Leak
acoates-ms pushed a commit to acoates-ms/react-native-windows that referenced this pull request Oct 16, 2024
* Support AccessibilityState: Busy

* Change files

* Add Testing

* Update Snapshots

* Update for Leak
acoates-ms pushed a commit to acoates-ms/react-native-windows that referenced this pull request Oct 16, 2024
* Support AccessibilityState: Busy

* Change files

* Add Testing

* Update Snapshots

* Update for Leak
acoates-ms added a commit that referenced this pull request Oct 16, 2024
* [Fabric] Implement IExpandCollapseProvider  (#13892)

* Implement IExpandCollapseProvider

* Change files

* Adjust Example

* Format + Update Snapshots

* [Fabric] implement tooltip property (#13941)

* [Fabric] implement view tooltip property

* format

* Change files

* update

* Fix lingering tooltip if component is unmounted while tooltip showing

* snapshot

---------

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

* Fix RootComponentView leak (#13959)

* Fix RootComponentView leak

* Change files

* format

---------

Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>

* Add Support for AccessibilityState:Busy (#13952)

* Support AccessibilityState: Busy

* Change files

* Add Testing

* Update Snapshots

* Update for Leak

---------

Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com>
Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
acoates-ms added a commit that referenced this pull request Oct 16, 2024
* [Fabric] Implement IExpandCollapseProvider  (#13892)

* Implement IExpandCollapseProvider

* Change files

* Adjust Example

* Format + Update Snapshots

* [Fabric] implement tooltip property (#13941)

* [Fabric] implement view tooltip property

* format

* Change files

* update

* Fix lingering tooltip if component is unmounted while tooltip showing

* snapshot

---------

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

* Fix RootComponentView leak (#13959)

* Fix RootComponentView leak

* Change files

* format

---------

Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>

* Add Support for AccessibilityState:Busy (#13952)

* Support AccessibilityState: Busy

* Change files

* Add Testing

* Update Snapshots

* Update for Leak

* Update change files to use patch instead of prerelease

* fix

* Update snapshot

---------

Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com>
Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
acoates-ms added a commit that referenced this pull request Oct 16, 2024
* Add Support for AccessibilityState:Busy (#13952)

* Support AccessibilityState: Busy

* Change files

* Add Testing

* Update Snapshots

* Update for Leak

* Fix RootComponentView leak (#13959)

* Fix RootComponentView leak

* Change files

* format

---------

Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>

* [Fabric] implement tooltip property (#13941)

* [Fabric] implement view tooltip property

* format

* Change files

* update

* Fix lingering tooltip if component is unmounted while tooltip showing

* snapshot

---------

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

* [Fabric] Implement IExpandCollapseProvider  (#13892)

* Implement IExpandCollapseProvider

* Change files

* Adjust Example

* Format + Update Snapshots

* Change files prerelease->patch

* update snapshots

---------

Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com>
Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment