-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for AccessibilityState:Busy #13952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Accessibility
Area: ActivityIndicator
Area: Component Views
Area: Fabric
Support Facebook Fabric
Area: Image
Area: Modal
Area: RefreshControl
Area: ScrollView
Area: Switch
Area: Text
Area: TextInput
Area: View
Area: View Props
https://reactnative.dev/docs/view#props
Parity: Fabric vs. Paper
RNW Fabric does not look or behave like RNW Paper
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
labels
Oct 9, 2024
danielayala94
requested changes
Oct 10, 2024
packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
The issue/PR needs activity from its author (label drives bot activity)
label
Oct 10, 2024
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
The issue/PR needs activity from its author (label drives bot activity)
label
Oct 11, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
danielayala94
approved these changes
Oct 11, 2024
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Oct 16, 2024
* Support AccessibilityState: Busy * Change files * Add Testing * Update Snapshots * Update for Leak
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Oct 16, 2024
* Support AccessibilityState: Busy * Change files * Add Testing * Update Snapshots * Update for Leak
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Oct 16, 2024
* Support AccessibilityState: Busy * Change files * Add Testing * Update Snapshots * Update for Leak
acoates-ms
added a commit
that referenced
this pull request
Oct 16, 2024
* [Fabric] Implement IExpandCollapseProvider (#13892) * Implement IExpandCollapseProvider * Change files * Adjust Example * Format + Update Snapshots * [Fabric] implement tooltip property (#13941) * [Fabric] implement view tooltip property * format * Change files * update * Fix lingering tooltip if component is unmounted while tooltip showing * snapshot --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> * Fix RootComponentView leak (#13959) * Fix RootComponentView leak * Change files * format --------- Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> * Add Support for AccessibilityState:Busy (#13952) * Support AccessibilityState: Busy * Change files * Add Testing * Update Snapshots * Update for Leak --------- Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
acoates-ms
added a commit
that referenced
this pull request
Oct 16, 2024
* [Fabric] Implement IExpandCollapseProvider (#13892) * Implement IExpandCollapseProvider * Change files * Adjust Example * Format + Update Snapshots * [Fabric] implement tooltip property (#13941) * [Fabric] implement view tooltip property * format * Change files * update * Fix lingering tooltip if component is unmounted while tooltip showing * snapshot --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> * Fix RootComponentView leak (#13959) * Fix RootComponentView leak * Change files * format --------- Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> * Add Support for AccessibilityState:Busy (#13952) * Support AccessibilityState: Busy * Change files * Add Testing * Update Snapshots * Update for Leak * Update change files to use patch instead of prerelease * fix * Update snapshot --------- Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com>
acoates-ms
added a commit
that referenced
this pull request
Oct 16, 2024
* Add Support for AccessibilityState:Busy (#13952) * Support AccessibilityState: Busy * Change files * Add Testing * Update Snapshots * Update for Leak * Fix RootComponentView leak (#13959) * Fix RootComponentView leak * Change files * format --------- Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> * [Fabric] implement tooltip property (#13941) * [Fabric] implement view tooltip property * format * Change files * update * Fix lingering tooltip if component is unmounted while tooltip showing * snapshot --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> * [Fabric] Implement IExpandCollapseProvider (#13892) * Implement IExpandCollapseProvider * Change files * Adjust Example * Format + Update Snapshots * Change files prerelease->patch * update snapshots --------- Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Accessibility
Area: ActivityIndicator
Area: Component Views
Area: Fabric
Support Facebook Fabric
Area: Image
Area: Modal
Area: RefreshControl
Area: ScrollView
Area: Switch
Area: Text
Area: TextInput
Area: View Props
https://reactnative.dev/docs/view#props
Area: View
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Parity: Fabric vs. Paper
RNW Fabric does not look or behave like RNW Paper
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Add support for AccessibilityState:Busy
Resolves #13327
Resolves #13066
Resolves #13062
Resolves #13058
Resolves #13054
Resolves #13050
Resolves #13046
Resolves #13042
Resolves #13038
Resolves #13034
What
Testing
TODO
Changelog
Should this change be included in the release notes: Yes
Add support for accessibilityState: busy to Fabric.