Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.74] Cherry-pick changes #13980

Merged
merged 7 commits into from
Oct 16, 2024
Merged

[0.74] Cherry-pick changes #13980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
01fe04b
[Fabric] Implement IExpandCollapseProvider (#13892)
chiaramooney Oct 9, 2024
249b51c
[Fabric] implement tooltip property (#13941)
acoates-ms Oct 11, 2024
e2b661c
Fix RootComponentView leak (#13959)
acoates-ms Oct 11, 2024
ec2a291
Add Support for AccessibilityState:Busy (#13952)
chiaramooney Oct 14, 2024
62cf2c8
Update change files to use patch instead of prerelease
acoates-ms Oct 16, 2024
12fb7f6
fix
acoates-ms Oct 16, 2024
7478802
Update snapshot
acoates-ms Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion change/@react-native-windows-codegen-8d6e2cd0-f94e-4aea-93b7-ac7b5edb0529.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "[Fabric] Add FocusNavigationDirection and allow overriding of default command handling",
"packageName": "@react-native-windows/codegen",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-061e13a1-aed7-4c50-b382-f49b0863935b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "[Fabric] Fix crash when running inspect",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
7 changes: 7 additions & 0 deletions change/react-native-windows-0d909f6f-4b48-46c7-97ec-c61c5f2b8087.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Support AccessibilityState: Busy",
"packageName": "react-native-windows",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion change/react-native-windows-35fe2283-4a8f-4316-8159-4f399c3fbe8f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "[Fabric] LogBox should destroy its window on instance shutdown",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-40511e3c-feb7-429f-9b7f-22d0ba2f9dc1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Use a legacy native module binding that always returns null in bridgeless mode",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
7 changes: 7 additions & 0 deletions change/react-native-windows-408fe985-f784-4dff-aed3-9045a0c7a420.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix RootComponentView leak",
"packageName": "react-native-windows",
"email": "53619745+rnbot@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/react-native-windows-4cf47ab7-542b-4ccb-bc2e-46c79be1bb02.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "[Fabric] implement view tooltip property",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion change/react-native-windows-53895955-fc85-4bdd-bf07-423af7773f83.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "[Fabric] Add FocusNavigationDirection and allow overriding of default command handling",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-61e991a4-b01f-44ee-a7a3-43a6d7f79eb1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "[Fabric] Enable ScrollView touch scrolling",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-6a82bdc7-fdc0-4d57-bd42-cb297ef7a7ea.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Implement SampleTurboModule",
"packageName": "react-native-windows",
"email": "jthysell@microsoft.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-8fc62f61-155f-45b2-824c-26d42a3281cb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "SampleTurboModule only works as a turbomodule, so do not install it when using web debugger",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
7 changes: 7 additions & 0 deletions change/react-native-windows-9696c96d-9a44-4ffc-84ea-dd5451818206.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Implement IExpandCollapseProvider",
"packageName": "react-native-windows",
"email": "34109996+chiaramooney@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion change/react-native-windows-96eb3191-d3a4-40fa-910c-c016a99977f7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Update SampleAppFabric to use ReactNativeAppBuilder",
"packageName": "react-native-windows",
"email": "10109130+sharath2727@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-af1ca5e8-ba4b-496c-a7ca-2c9e3ffd32c1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Introduce ReactNativeAppBuilder.idl",
"packageName": "react-native-windows",
"email": "10109130+sharath2727@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-b2ad5990-4475-4b62-9ec8-6ddd45ba06be.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Add Implementation for accessibilityActions",
"packageName": "react-native-windows",
"email": "34109996+chiaramooney@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-b64d95ea-c807-42e3-8bc9-4213bd67d886.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Setup reactnativewin32 app",
"packageName": "react-native-windows",
"email": "10109130+sharath2727@users.noreply.github.com",
Expand Down
2 changes: 1 addition & 1 deletion change/react-native-windows-b828ab6b-3220-4d51-b6c9-3db3b91887c1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "prerelease",
"type": "patch",
"comment": "[Fabric] LayoutDirection and FontSizeMultiplier support",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
Expand Down
26 changes: 15 additions & 11 deletions packages/@react-native-windows/tester/src/js/examples/View/ViewExample.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ class AccessibilityExample extends React.Component<
> {
state: {tap: number} = {
tap: 0,
expanded: true,
};

render(): React.Node {
Expand All @@ -473,28 +474,31 @@ class AccessibilityExample extends React.Component<
accessibilityRole="button"
accessibilityValue={0}
accessibilityActions={[
{name: 'cut', label: 'cut'},
{name: 'copy', label: 'copy'},
{name: 'paste', label: 'paste'},
{name: 'expand', label: 'expand'},
{name: 'collapse', label: 'collapse'},
]}
accessibilityState={{expanded: this.state.expanded, busy: true}}
accessibilityPosInSet={1}
accessibilitySetSize={1}
accessibilityLiveRegion="polite"
testID="accessibility"
accessible
focusable
onAccessibilityAction={event => {
switch (event.nativeEvent.actionName) {
case 'cut':
Alert.alert('Alert', 'cut action success');
break;
case 'copy':
Alert.alert('Alert', 'copy action success');
break;
case 'paste':
Alert.alert('Alert', 'paste action success');
case 'expand':
this.setState({expanded: true});
break;
case 'collapse':
this.setState({expanded: false});
}
}}
onAccessibilityTap={() => {
this.setState({tap: this.state.tap + 1});
}}
onPress={() => {
this.setState({expanded: !this.state.expanded});
console.log('Pressed');
}}>
<Text>A View with accessibility values.</Text>
<Text>Current Number of Accessibility Taps: {this.state.tap}</Text>
Expand Down
63 changes: 59 additions & 4 deletions packages/e2e-test-app-fabric/test/__snapshots__/ViewComponentTest.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,10 +1094,15 @@ exports[`View Tests Views can have customized accessibility 1`] = `
"Automation Tree": {
"AutomationId": "accessibility",
"ControlType": 50000,
"ExpandCollapsePattern.ExpandCollapseState": "Expanded",
"HelpText": "Accessibility Hint",
"IsKeyboardFocusable": true,
"ItemStatus": "Busy",
"LiveSetting": "Polite",
"LocalizedControlType": "button",
"Name": "A View with accessibility values",
"PositionInSet": 1,
"SizeofSet": 1,
"__Children": [
{
"AutomationId": "",
Expand Down Expand Up @@ -6021,12 +6026,24 @@ exports[`View Tests Views can have tooltips 1`] = `
"_Props": {},
},
{
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
"Type": "Microsoft.ReactNative.Composition.ViewComponentView",
"_Props": {},
"__Children": [
{
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
"_Props": {},
},
],
},
{
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
"Type": "Microsoft.ReactNative.Composition.ViewComponentView",
"_Props": {},
"__Children": [
{
"Type": "Microsoft.ReactNative.Composition.ParagraphComponentView",
"_Props": {},
},
],
},
],
},
Expand Down Expand Up @@ -6062,6 +6079,25 @@ exports[`View Tests Views can have tooltips 1`] = `
"Offset": "0, 0, 0",
"Size": "916, 15",
"Visual Type": "SpriteVisual",
"__Children": [
{
"Offset": "0, 0, 0",
"Size": "916, 15",
"Visual Type": "SpriteVisual",
"__Children": [
{
"Offset": "0, 0, 0",
"Size": "916, 15",
"Visual Type": "SpriteVisual",
},
{
"Offset": "0, 0, 0",
"Size": "0, 0",
"Visual Type": "SpriteVisual",
},
],
},
],
},
{
"Offset": "0, 0, 0",
Expand All @@ -6072,13 +6108,32 @@ exports[`View Tests Views can have tooltips 1`] = `
},
{
"Offset": "0, 29, 0",
"Size": "916, 16",
"Size": "916, 14",
"Visual Type": "SpriteVisual",
"__Children": [
{
"Offset": "0, 0, 0",
"Size": "916, 16",
"Size": "916, 14",
"Visual Type": "SpriteVisual",
"__Children": [
{
"Offset": "0, 0, 0",
"Size": "916, 16",
"Visual Type": "SpriteVisual",
"__Children": [
{
"Offset": "0, 0, 0",
"Size": "916, 16",
"Visual Type": "SpriteVisual",
},
{
"Offset": "0, 0, 0",
"Size": "0, 0",
"Visual Type": "SpriteVisual",
},
],
},
],
},
{
"Offset": "0, 0, 0",
Expand Down
22 changes: 14 additions & 8 deletions packages/e2e-test-app-fabric/test/__snapshots__/snapshotPages.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83759,27 +83759,33 @@ exports[`snapshotAllPages View 20`] = `
accessibilityActions={
[
{
"label": "cut",
"name": "cut",
"label": "expand",
"name": "expand",
},
{
"label": "copy",
"name": "copy",
},
{
"label": "paste",
"name": "paste",
"label": "collapse",
"name": "collapse",
},
]
}
accessibilityHint="Accessibility Hint"
accessibilityLabel="A View with accessibility values"
accessibilityLiveRegion="polite"
accessibilityPosInSet={1}
accessibilityRole="button"
accessibilitySetSize={1}
accessibilityState={
{
"busy": true,
"expanded": true,
}
}
accessibilityValue={0}
accessible={true}
focusable={true}
onAccessibilityAction={[Function]}
onAccessibilityTap={[Function]}
onPress={[Function]}
testID="accessibility"
>
<Text>
Expand Down
Loading
Loading