Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native dependency to 0.59 #2411

Merged
merged 5 commits into from
Jul 18, 2019
Merged

Conversation

rozele
Copy link
Collaborator

@rozele rozele commented May 4, 2019

Updates dependencies to match react-native@0.59, includes fixes to metro config, Alert module and updated reference to @react-native-community/cli

rozele added 2 commits May 3, 2019 14:48
Added windows platform moniker to metro config.

Temporarily removing the Alert module, follow on work to fix create the native / cross-platform alert manager based on changes to the Alert module in react-native@0.59.
@rozele rozele requested a review from a team as a code owner May 4, 2019 01:06
@rozele
Copy link
Collaborator Author

rozele commented May 4, 2019

Still needs some work updating references to @react-native-community/cli - cc @in4margaret, in case you have some time to take a look.

@rozele
Copy link
Collaborator Author

rozele commented May 4, 2019

Fixed issue with template generator, one more issue to resolve for metro in generated projects.

@matthargett
Copy link
Contributor

doesn't Yoga also need to be synced?

@matthargett
Copy link
Contributor

I'm tracking an upstream issue where apps for out-of-tree platforms get this error when trying to run jest tests after an upgrade to 0.59:
facebook/react-native#20460

The error is the same, but the reasons appear to be different than those mentioned in the thread.
I can reproduce when I try adding a jest test to the Playground app. @rozele @acoates-ms, can you reproduce?

@rozele
Copy link
Collaborator Author

rozele commented Jun 21, 2019

@matthargett good point - I'll also update yoga

@rozele rozele added AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) rnwcs labels Jun 21, 2019
@ghost
Copy link

ghost commented Jun 21, 2019

Hello @rozele!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@rozele
Copy link
Collaborator Author

rozele commented Jun 21, 2019

@matthargett - on second thought - I'll time box the fixes to update to the latest Yoga, as every upgrade seems to result in breaking changes to layout. If it takes more than a couple hours, we'll ship 0.59 as is and add a backlog item to get Yoga updated.

@rozele
Copy link
Collaborator Author

rozele commented Jun 21, 2019

Ugh - seemed to be an issue with enum bitfields 🙄. Disabling those fixes the layout.

@timols
Copy link

timols commented Jul 2, 2019

Hi @rozele, any updates on this PR? Android is requiring 64bit builds as of Aug 1 which naturally places some time pressure on this upgrade in order to maintain platform compatibility across iOS, Android and Windows.

@rozele rozele merged commit f48ed03 into microsoft:master Jul 18, 2019
@rozele rozele deleted the 0.59-dev branch July 18, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants