Integrate top level ReactInstanceManager changes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty for react-native
In addition to some minor cosmetic changes, this changeset also fixes up the IReactPackage interface and more closely mimics the way IReactPackage is used in the ReactInstanceManagerImpl in ReactAndroid to support loading multiple packages into one NativeModuleRegistry and one JavaScriptModulesConfig.
…ipt thread queue.
|
|
| @@ -3,6 +3,7 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.Threading.Tasks; | |||
| using ReactNative.Bridge.Queue; | |||
There was a problem hiding this comment.
This namespace needs to be sorted.
…ct-native into ReactWindows-ES
Also adds two-phase initialization of the ChakraJavaScriptExecutor so the instance can be created off the JavaScript thread. Also fixes a bug with the UIManagerModule constants and adds unit tests for custom event types and constant overloading by view managers. Also adds a simple base interface (IViewManager) for view managers to hold names and constants.
Fixes #62 - Adds EventDispatcher
Adds various other stubs that we will need to implement as we move forward.
…ttribute Adding attributes to match the Java annotations for @ReactProp and @ReactPropGroup, along with unit tests.
…ct-native into ReactWindows-ES
Remaining TODOs surrounding layout, popup menu, measurement, etc.
Towards #70 - Adds implementation for NativeViewHierarchyManager
…Currently working with JFox to help with debugging the issue
The ReactShadowNode implementation derives from CSSNode. Rather than port over the entire csslayout project that Facebook created, we're using a compiled binary (checked in) from https://github.com/pragmatrix/css-layout. We needed to hook into the `dirty` method, so there is one small modification to the library.
rozele
pushed a commit
that referenced
this pull request
Jun 21, 2019
Remove "not used in production" warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.