Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement accessibilityState (#4617) #4624

Merged
5 commits merged into from
Apr 17, 2020

Conversation

kmelmon
Copy link
Contributor

@kmelmon kmelmon commented Apr 16, 2020

cherry-pick of 9718f84 into 0.61-stable

* Implement AccessibilityState

* formatting

* Change files

* bring back accessibilityStates to port back to 0.61

* formatting

* handle mixed state

* update test

* prettier fixes
@kmelmon kmelmon marked this pull request as ready for review April 16, 2020 19:15
@kmelmon kmelmon requested a review from a team as a code owner April 16, 2020 19:15
Copy link
Collaborator

@NickGerleman NickGerleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmelmon would you mind also replacing "prerelease" with "patch" in your changefile? Due to a Beachball bug we will otherwise no-op instead of showing an error, since we disallow pre-release bumps for stable branches.

@kenotron @acoates-ms we should really try to fix this bug.

@kmelmon
Copy link
Contributor Author

kmelmon commented Apr 16, 2020

done. the commit message says it all...


In reply to: 395017337 [](ancestors = 395017337)

@kmelmon kmelmon added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 16, 2020
@ghost
Copy link

ghost commented Apr 16, 2020

Hello @kmelmon!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 406078b into microsoft:0.61-stable Apr 17, 2020
@kmelmon kmelmon deleted the accessibility-state-cherrypick branch April 23, 2020 21:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants