Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate May 19th RN nightly build. #7968

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

rectified95
Copy link
Contributor

@rectified95 rectified95 commented Jun 8, 2021

Commits: facebook/react-native@903eae4...b2ec89f
Not much of interest:

  • verified the looping animations fixed upstream also work in RNW;
  • new parsing parameters added to our fork of vnext/src/babel-plugin-codegen/index.js
Microsoft Reviewers: Open in CodeFlow

@rectified95 rectified95 requested a review from a team as a code owner June 8, 2021 00:54
@@ -144,8 +144,11 @@ module.exports = function({parse, types: t}) {
const viewConfig = generateViewConfig(this.filename, this.code);
this.defaultExport.replaceWithMultiple(
// [Win adding filename param see: https://github.com/facebook/react-native/pull/29230
parse(viewConfig, {filename: this.filename}).program.body,
// Win]
parse(viewConfig, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acoates-ms/@adamfoxmann : Just FYI, as this seems to disable babelrc. Not sure if it affects what you are working on.

Igor Klemenski added 2 commits June 8, 2021 00:32
@rectified95 rectified95 merged commit 2ba41a4 into microsoft:main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants