fixed text measurement regression #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
reviewed
Feb 8, 2017
| @@ -213,8 +213,8 @@ private static YogaSize MeasureText(ReactTextShadowNode textNode, YogaNode node, | |||
| var normalizedHeight = YogaConstants.IsUndefined(height) ? double.PositiveInfinity : height; | |||
| textBlock.Measure(new Size(normalizedWidth, normalizedHeight)); | |||
| return MeasureOutput.Make( | |||
| (float)textBlock.DesiredSize.Width, | |||
| (float)textBlock.DesiredSize.Height); | |||
| (float)Math.Ceiling(textBlock.DesiredSize.Width), | |||
There was a problem hiding this comment.
Ceiling [](start = 32, length = 7)
That's strange that cropping occurs on WPF and not on UWP. We were going to use the same technique for UWP, but fixed the rounding issue in Yoga. facebook/yoga#300
There was a problem hiding this comment.
does that mean we should publish a new package (same hash they published to npm/cocoapods), and then update our version reference to fix the issue?
There was a problem hiding this comment.
I actually think this is also a problem on UWP still too. Can you add the Math.Ceiling to UWP as well?
|
|
rozele
pushed a commit
that referenced
this pull request
Feb 10, 2017
* fixed text measurement regression * also apply fix to UWP text * also applied fix to textinput
rozele
pushed a commit
that referenced
this pull request
Feb 15, 2017
* fixed text measurement regression * also apply fix to UWP text * also applied fix to textinput
rozele
pushed a commit
that referenced
this pull request
Feb 15, 2017
* fixed text measurement regression * also apply fix to UWP text * also applied fix to textinput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't round up the text always gets clipped.