Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactXP not compatible with react-native 0.65 without patch #1319

Open
mikehardy opened this issue Aug 23, 2021 · 8 comments · Fixed by aajahid/reactxp#2
Open

ReactXP not compatible with react-native 0.65 without patch #1319

mikehardy opened this issue Aug 23, 2021 · 8 comments · Fixed by aajahid/reactxp#2

Comments

@mikehardy
Copy link
Contributor

AccessibilityInfo.fetch was finally removed, this PR needs a merge+release for ReactXP to work with react-native 0.65+: #1126

If anyone else runs into this, there's a patch-package / https://github.com/ds300/patch-package format patch attached on the PR, works

@mikehardy
Copy link
Contributor Author

@fbartho @deregtd @berickson1 @msfterictraut sincere apologies for the direct ping just wanted to mention that without the pull request linked here, which was reviewed and only on pause while we waited for a compatibility window (that has passed I think...) reactxp does not work at all with react-native 0.65+ as the deprecated accessibility property the PR moves away from was finally dropped

@berickson1
Copy link
Collaborator

To be perfectly honest, I haven't kept up with react-native for the last year or so due to shifting job responsibilities. That being said, it does sound reasonable to make this breaking change that bumps the minimum RN version and change the usage of this API

@mikehardy
Copy link
Contributor Author

Thanks @berickson1 - I just saw @erictraut merge some dependabot PRs using that handle vs mserictraut, perhaps he's the best ping with that handle :-)

@erictraut
Copy link
Contributor

Hi @mikehardy, yes I've been merging dependabot PRs because it takes just a second, but I haven't been involved in any of the recent substantive discussions related to reactxp. I unfortunately don't have any time to dedicate to it at this time.

@kg-currenxie
Copy link
Contributor

kg-currenxie commented Oct 7, 2021

Same here. Needing patch to upgrade to 0.65. 0.66 is already out as well. More people are likely to run into this issue

@realityworks
Copy link

Project is no longer supported... This is why cross platform is dangerous.

@mikehardy
Copy link
Contributor Author

mikehardy commented Nov 3, 2021

This is why cross platform is dangerous.

I love making sweeping generalizations from one project as well! Open source comments are also super dangerous ;-)

I think in reality it is just that react-native-web "won" the mindshare here, at the same time that microsoft poured a bunch of resources into real macos and windows ports (have you seen those? they're quite lively!) meaning this repo is just not really needed.

Best part though: ReactXP just enabled you to write pretty-much standard react-native code which is still dangerously cross platform, so you can probably just drop your ReactXP code right into a react-native / react-native-web template (try https://github.com/plaut-ro/luna but be careful, it's cross-platform) and it'll go.

@mikehardy
Copy link
Contributor Author

Here's some more dangerously cross-platform stuff, one line command to init react-native-web + typescript + firebase with a fully built-out authentication signed-out/signed-in flow https://github.com/invertase/react-native-firebase-authentication-example/ - if you're not careful it will work on all platforms though, so take care using it

aajahid added a commit to aajahid/reactxp that referenced this issue Jul 18, 2022
…-native 0.60 API

React-Native 0.59 -> 0.60 changed a lot of the AccessibilityInfo API, and this does a straight forward-port of existing functionality (screen reader status detection) to the new API.

Here is the related PR facebook/react-native-website#835

And the doc with new APIs https://facebook.github.io/react-native/docs/accessibilityinfo

This depends on the PR here for types I believe DefinitelyTyped/DefinitelyTyped#37486

There is an opportunity to also expand API coverage to cover the other new accessibility features react-native exposes but if this is desired it might be best to do it separately? Additionally the majority are iOS-specific so if I proposed that change I'd need some guidance.

Fixes microsoft#1319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants