Making gesture views accessibile #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asen/gestureview_accessibility
…esture views. Also make gesture views accessible by default as it generally always has actions that can be perfomed on them by the users. and hence needs to b exposed to screen readers as well
|
@RamyaSenk, |
erictraut
suggested changes
Aug 4, 2017
src/native-common/GestureView.tsx
Outdated
| return ( | ||
| <RN.View | ||
| style={ this._getStyles(this.props) } | ||
| style={this._getStyles(this.props)} |
There was a problem hiding this comment.
Please add spaces within the curly brackets to be consistent with all other code in ReactXP.
There was a problem hiding this comment.
Done. Updated it.
|
Thanks @erictraut I have updated the document and fixed spaces. I missed web, have implemented accessibility props in there as well. |
erictraut
approved these changes
Aug 4, 2017
berickson1
pushed a commit
to berickson1/reactxp
that referenced
this pull request
Oct 22, 2018
* Makign Gesture view accessibility property to true * Exposing accessibility property in gesture view * Making gesture Views accessibile. Expose the accessibility props in gesture views. Also make gesture views accessible by default as it generally always has actions that can be perfomed on them by the users. and hence needs to b exposed to screen readers as well * Removing gesture dist file * Updating documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we cannot recognise swipe and pan gestures when screen reader is enabled. Making gesture views implement accessibility properties. Also making gesture views accessible by default because it is associated with actions done on the view - which should almost always be accessible. Similar to button behaviour.
You can test these gestures by long pressing on the gesture view and performing the gesture like swipe and pan.