Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Docfx to 2.59.4 #1860

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Bump Docfx to 2.59.4 #1860

merged 1 commit into from
Sep 14, 2022

Conversation

MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Sep 14, 2022 •
edited
Loading

Fixes #1859

A recent update of MSBuild seems to have broken a bunch of stuff, including docfx.
Some discussion on dotnet/docfx#8097 and dotnet/docfx#8136.

Docfx added a workaround dotnet/docfx#8135 that is now released in 2.59.4.
It solves the issue for me when testing locally.

[22-09-07 10:52:17.669]Warning:MetadataCommand.ExtractMetadataWorkspace failed with: [Failure] Msbuild failed when processing the file 'D:\a\reverse-proxy\reverse-proxy\source\src\ReverseProxy\Yarp.ReverseProxy.csproj' with message: Method not found: 'System.ReadOnlySpan1<Char> Microsoft.IO.Path.GetFileName(System.ReadOnlySpan1)'.

@MihaZupan MihaZupan added this to the YARP 2.0.0 milestone Sep 14, 2022
@MihaZupan MihaZupan requested a review from Tratcher as a code owner September 14, 2022 11:07
This was referenced Sep 14, 2022
Merged
Closed
@Tratcher Tratcher merged commit 46af7e6 into microsoft:release/latest Sep 14, 2022
@Tratcher Tratcher modified the milestones: YARP 2.0.0, YARP 1.1.x Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MihaZupan @Tratcher