-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change arm-unknown-linux-gnueabihf
to musl
#25
Conversation
Originally, I was thinking to change the arm32 build from using gnu to musl, but the musl equivalent of Perhaps a better way to approach this is to run this in the same docker container as vscode core does. Using the container from https://github.com/microsoft/vscode/blob/1da1092e6587b1deec454c7bb49dbd7ba3b0e90b/build/azure-pipelines/product-build.yml#L151, we can try to run the arm32 build. I think we'd be using docker qemu like in https://github.com/microsoft/vscode/blob/13819daa5f83313957c4eb1698797c9448155c90/build/azure-pipelines/linux/product-build-linux-server.yml#L83-L95 |
Going to instead change the docker image that this build uses in order to solve this bug. |
Fixes #24
It seems that rust supports a musl version of
arm-unknown-linux-gnueabihf
, so use that one. Since we are cross-compiling, we don't need the host tool support.https://doc.rust-lang.org/nightly/rustc/platform-support.html