Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-aarch64 no longer allows for 16K page size #28

Merged
merged 5 commits into from
Jun 6, 2023
Merged

linux-aarch64 no longer allows for 16K page size #28

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3cb4a63
linux-aarch64 no longer allows for 16K page size
andreamah Jun 5, 2023
276f6ad
remove conditional for non arm cases
andreamah Jun 6, 2023
76aba3b
Update build/build.sh
andreamah Jun 6, 2023
91eaac5
Update build/build.sh
andreamah Jun 6, 2023
9120cb4
chore: cleanup conditions
deepak1556 Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,17 @@ set -ex
main() {
CARGO="$(builder)"

if is_linux && is_musl; then
# jemalloc doesn't allow 16K page sizes for linux musl
# https://github.com/microsoft/ripgrep-prebuilt/issues/26
JEMALLOC_SYS_WITH_LG_PAGE=14
fi

# Test a normal debug build.
if is_arm || is_aarch64 || is_ppc64le; then
"$CARGO" build --target "$TARGET" --release --features 'pcre2'
# pcre2 is not supported on s390x
# https://github.com/zherczeg/sljit/issues/89
elif is_s390x; then
"$CARGO" build --release --target=$TARGET
elif is_aarch64_musl; then
andreamah marked this conversation as resolved.
Show resolved Hide resolved
# force jemalloc to allow 16K page sizes for linux musl
# https://github.com/microsoft/ripgrep-prebuilt/issues/26
JEMALLOC_SYS_WITH_LG_PAGE=14 "$CARGO" build --target "$TARGET" --release --features 'pcre2'
else
# Technically, MUSL builds will force PCRE2 to get statically compiled,
# but we also want PCRE2 statically build for macOS binaries.
Expand Down