chore: change Rust version to stable #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be more stable to fix the build to a certain version? |
|
It would be less likely for the build to break if we stayed with a constant version of Rust, but the pipeline would fall behind more often. I noticed the Windows jobs already use the latest stable when building Rust. Do the Linux jobs have more specific Rust version requirements? |
|
I believe that there were issues with the musl build and minimum glibc requirements on Linux #24. I think the purpose of fixing the version was because this process is a little fragile and I'll need to go back to look at it to know what the best way to handle this is. |
|
Closing this PR. code-cli is also manually bumping Rust versions at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we always use the latest stable Rust when building ripgrep for Linux.
Verification build: https://dev.azure.com/vscode/ripgrep-prebuilt/_build/results?buildId=118999&view=results