test(esbuild-bundle-analyzer): address pnpm issues

.changeset/proud-keys-lay.md

@@ -0,0 +1,2 @@
+---
+---

incubator/esbuild-bundle-analyzer/package.json

@@ -44,6 +44,7 @@
     "@rnx-kit/jest-preset": "*",
     "@rnx-kit/scripts": "*",
     "@rnx-kit/tools-node": "^2.0.0",
+    "@types/jest": "^29.2.1",
     "@types/node": "^18.0.0",
     "@types/yargs": "^16.0.0",
     "eslint": "^8.0.0",

incubator/esbuild-bundle-analyzer/test/__mocks__/fs.js

@@ -1,24 +1,11 @@
-// Copied from metro-plugin-duplicates-checker/test/__mocks__/fs.js
-const fs = jest.createMockFromModule("node:fs");
-const actualFs = jest.requireActual("node:fs");
-
-// Under normal circumstances, this extra copy of '@react-native/polyfills'
-// should not be installed.
-const extraPolyfills =
-  "/packages/test-app/node_modules/@react-native/polyfills";
-
-fs.readFileSync = actualFs.readFileSync;
-
-fs.realpathSync = actualFs.realpathSync;
-const actualRealpathSyncNative = actualFs.realpathSync.native;
-fs.realpathSync.native = (path, ...args) => {
-  if (path.replace(/\\/g, "/").endsWith(extraPolyfills)) {
-    return path;
-  } else {
-    return actualRealpathSyncNative(path, ...args);
-  }
+const fs = require("@rnx-kit/metro-plugin-duplicates-checker/test/__mocks__/fs.js");
+const fsActual = jest.requireActual("fs");
+
+const readFileSync = fs.readFileSync;
+fs.readFileSync = (p, options) => {
+  return p.includes("__fixtures__")
+    ? fsActual.readFileSync(p, options)
+    : readFileSync(p, options);
 };
 
-fs.statSync = actualFs.statSync; // Used by 'pkg-dir'
-
 module.exports = fs;

incubator/esbuild-bundle-analyzer/test/duplicates.test.ts

@@ -10,50 +10,13 @@ import {
   file50Path,
   firstDuplicate,
   inputWithDuplicates,
+  inputWithDuplicatesFS,
   inputWithoutDuplicates,
-  repoRoot,
 } from "./testData";
 
-const fixturePath = path.join(process.cwd(), "test", "__fixtures__");
+const fixturePath = path.join(__dirname, "__fixtures__");
 
 jest.mock("fs");
-jest.mock("@rnx-kit/tools-node/package");
-
-// Under normal circumstances, this extra copy of '@react-native/polyfills'
-// should not be installed.
-// Copied from metro-plugin-duplicates-checker/test/checkForDuplicatePackages.test.ts
-const extraPolyfills = `${repoRoot.replace(
-  /\\/g,
-  "/"
-)}/packages/test-app/node_modules/@react-native/polyfills`;
-require("@rnx-kit/tools-node/package").findPackageDir = jest
-  .fn()
-  .mockImplementation((startDir) => {
-    switch (startDir) {
-      // Under normal circumstances, this extra copy of '@react-native/polyfills'
-      // should not be installed.
-      case `${extraPolyfills}/index.js`:
-        return extraPolyfills;
-      default:
-        return jest
-          .requireActual("@rnx-kit/tools-node/package")
-          .findPackageDir(startDir);
-    }
-  });
-require("@rnx-kit/tools-node/package").readPackage = jest
-  .fn()
-  .mockImplementation((path) => {
-    if (path.replace(/\\/g, "/").includes(extraPolyfills)) {
-      return {
-        name: "@react-native/polyfills",
-        version: "1.0.0",
-      };
-    } else {
-      return jest
-        .requireActual("@rnx-kit/tools-node/package")
-        .readPackage(path);
-    }
-  });
 
 describe("generateGraph()", () => {
   test("generateGraph", () => {
@@ -135,13 +98,21 @@ describe("getWhyDuplicatesInBundle()", () => {
 });
 
 describe("getDuplicates()", () => {
-  expect(getDuplicates(inputWithoutDuplicates, "")).toEqual({
-    banned: 0,
-    duplicates: 0,
-  });
+  const fs = require("fs");
+
+  afterAll(() => fs.__setMockFiles());
 
-  expect(getDuplicates(inputWithDuplicates, "")).toEqual({
-    banned: 0,
-    duplicates: 1,
+  test("finds duplicates", () => {
+    fs.__setMockFiles(inputWithDuplicatesFS);
+
+    expect(getDuplicates(inputWithoutDuplicates, "")).toEqual({
+      banned: 0,
+      duplicates: 0,
+    });
+
+    expect(getDuplicates(inputWithDuplicates, "")).toEqual({
+      banned: 0,
+      duplicates: 1,
+    });
   });
 });

incubator/esbuild-bundle-analyzer/test/testData.ts

@@ -2,8 +2,11 @@ import * as path from "node:path";
 import type { Input } from "../src/metafile";
 import type { Result } from "../src/types";
 
-const pkgDir = jest.requireActual("pkg-dir");
-export const repoRoot = pkgDir.sync(path.resolve(__dirname, "..", ".."));
+export const repoRoot = path.resolve(__dirname, "..", "..", "..");
+
+function makeManifest(name, version = "0.0.0") {
+  return JSON.stringify({ name, version });
+}
 
 export const inputWithDuplicates: Record<string, Input> = {};
 inputWithDuplicates[
@@ -92,6 +95,16 @@ inputWithDuplicates[`${repoRoot}/node_modules/chalk/source/index.js`] = {
   format: "cjs",
 };
 
+export const inputWithDuplicatesFS: Record<string, string> = {
+  "repo/node_modules/@apollo/client/package.json":
+    makeManifest("@apollo/client"),
+  "repo/packages/ra-ui-materialui/package.json":
+    makeManifest("ra-ui-materialui"),
+  [`${repoRoot}/node_modules/@rnx-kit/build/node_modules/chalk/package.json`]:
+    makeManifest("chalk"),
+  [`${repoRoot}/node_modules/chalk/package.json`]: makeManifest("chalk"),
+};
+
 export const inputWithoutDuplicates: Record<string, Input> = {
   "repo/node_modules/@apollo/client/utilities/globals/fix-graphql.js": {
     bytes: 237,

yarn.lock

@@ -3623,6 +3623,7 @@ __metadata:
     "@rnx-kit/metro-plugin-duplicates-checker": ^2.1.2
     "@rnx-kit/scripts": "*"
     "@rnx-kit/tools-node": ^2.0.0
+    "@types/jest": ^29.2.1
     "@types/node": ^18.0.0
     "@types/yargs": ^16.0.0
     chalk: ^4.1.0