Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix phantom dependencies #2778

Merged
merged 2 commits into from
Nov 2, 2023
Merged

chore: fix phantom dependencies #2778

merged 2 commits into from
Nov 2, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 2, 2023

Description

Fix phantom dependencies.

This is a first step towards enabling the pnpm linker and getting proper validation on CI that we're not breaking pnpm-like setups.

Test plan

n/a

@github-actions github-actions bot added feature: metro This is related to Metro chore Improvements that don't directly affect features feature: third party notices This is related to Third Party Notices feature: jest This is related to Jest feature: eslint This is related to ESLint feature: webapis This is related to the experimental effort around WebAPIs for RN labels Nov 2, 2023
@github-actions github-actions bot added the feature: cli This is related to CLI label Nov 2, 2023
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻 a bit late for spoooky season 👻

jokes aside, would love to hear how you figured those out, maybe tweak the PR body to mention how you found them?

@tido64
Copy link
Member Author

tido64 commented Nov 2, 2023

I alluded to it in the description. Basically this:

diff --git a/.yarnrc.yml b/.yarnrc.yml
index f9cc2ca3..b2cfdf1f 100644
--- a/.yarnrc.yml
+++ b/.yarnrc.yml
@@ -7,7 +7,7 @@ logFilters:
     level: discard
   - code: YN0013 # X can't be found in the cache and will be fetched from the remote registry
     level: discard
-nodeLinker: node-modules
+nodeLinker: pnpm
 npmRegistryServer: "https://registry.npmjs.org"
 packageExtensions:
   "@fluentui/utilities@*":

Then run yarn. It will fail on a bunch of things, so there are no good test steps right now.

@tido64 tido64 merged commit 067e2ed into main Nov 2, 2023
12 checks passed
@tido64 tido64 deleted the tido/fix-phantom-deps branch November 2, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements that don't directly affect features feature: cli This is related to CLI feature: eslint This is related to ESLint feature: jest This is related to Jest feature: metro This is related to Metro feature: third party notices This is related to Third Party Notices feature: webapis This is related to the experimental effort around WebAPIs for RN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants