Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up root dependencies #2809

Merged
merged 3 commits into from
Nov 9, 2023
Merged

chore: clean up root dependencies #2809

merged 3 commits into from
Nov 9, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 9, 2023

Description

Remove root dependencies that are no longer needed.

Test plan

Enable pnpm mode:

diff --git a/.yarnrc.yml b/.yarnrc.yml
index 1bf9d579..6771046f 100644
--- a/.yarnrc.yml
+++ b/.yarnrc.yml
@@ -7,7 +7,7 @@ logFilters:
     level: discard
   - code: YN0013 # X can't be found in the cache and will be fetched from the remote registry
     level: discard
-nodeLinker: node-modules
+nodeLinker: pnpm
 npmRegistryServer: "https://registry.npmjs.org"
 packageExtensions:
   "@fluentui/utilities@*":

Test everything:

yarn
yarn test

@tido64 tido64 requested a review from acoates-ms November 9, 2023 15:38
@github-actions github-actions bot added feature: metro This is related to Metro chore Improvements that don't directly affect features feature: cli This is related to CLI feature: webapis This is related to the experimental effort around WebAPIs for RN labels Nov 9, 2023
Base automatically changed from tido/pnpm/fix-bundle to main November 9, 2023 16:07
@tido64 tido64 merged commit 9ce04ee into main Nov 9, 2023
12 checks passed
@tido64 tido64 deleted the tido/pnpm/root-cleanup branch November 9, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements that don't directly affect features feature: cli This is related to CLI feature: metro This is related to Metro feature: webapis This is related to the experimental effort around WebAPIs for RN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants