Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metro service #326

Merged
merged 11 commits into from
Jun 28, 2021
Merged

Metro service #326

merged 11 commits into from
Jun 28, 2021

Conversation

afoxman
Copy link
Contributor

@afoxman afoxman commented Jun 28, 2021

Add a metro-service package for interacting with metro at an API level, rather than through its command-line interface.

Tests aren't written yet. Tracked by #325.

afoxman added 8 commits June 27, 2021 22:34
@afoxman
Add Metro types, and reorganize them into a file & directory structur…
e231afa 
…e that mirrors Metro. This makes it possible to keep track of what types we've ported, and what types we haven't. There are A LOT of types in Metro.
@afoxman
Fix types after metro type update
b695013
@afoxman
Change files
57627c2
@afoxman
fix change file description
4b39448
@afoxman
Add a metro-service package for interacting with metro at an API leve…
e73a6dd 
…l, rather than through its command-line interface.
@afoxman
update dependencies
3e3acae
@afoxman
add mkdirp dependency
eec0798
@afoxman
Change files
d87b4e4
@afoxman afoxman requested a review from tido64 June 28, 2021 05:58
@afoxman afoxman requested a review from JasonVMo as a code owner June 28, 2021 05:58
@github-actions
Copy link
Contributor

Changes were detected (e.g. due to formatters, linters, etc.) in the following files:

  • rnx-kit/README.md

    Line 37 in 98a6bc5

    | [@rnx-kit/metro-serializer-esbuild](https://github.com/microsoft/rnx-kit/tree/main/packages/metro-serializer-esbuild) | Experimental esbuild serializer for Metro |

Base automatically changed from afoxman/metro-types to main June 28, 2021 06:59
@afoxman afoxman enabled auto-merge (squash) June 28, 2021 07:19
@afoxman
Copy link
Contributor Author

afoxman commented Jun 28, 2021

This code is almost entirely ported as-is from the @react-native-community/cli project. I wanted to make sure our starting point for bundling was the same as what we'd been using up to this point.

@afoxman
Copy link
Contributor Author

afoxman commented Jun 28, 2021

I'll look at getting this upstreamed as a new @react-native-community CLI package, or maybe elsewhere. Need to discuss with grabbou. #328

tido64
tido64 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went very superficially through this since we don't want to deviate too much from upstream code.

packages/metro-service/src/asset/android.ts Show resolved Hide resolved
packages/metro-service/src/asset/android.ts Show resolved Hide resolved
packages/metro-service/src/asset/write.ts Show resolved Hide resolved
@afoxman afoxman merged commit e683dde into main Jun 28, 2021
@afoxman afoxman deleted the metro-service branch June 28, 2021 08:14
@tido64 tido64 added the feature: metro This is related to Metro label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: metro This is related to Metro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afoxman @tido64