New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade TypeScript to ~5.0.4. #4103

Merged

iclanton merged 8 commits into microsoft:main from iclanton:typescript-5

May 22, 2023

Member

iclanton commented May 5, 2023 •

edited

Loading

Summary

Upgrades TypeScript to ~5.0.4.

How it was tested

Ran the build. Everything passes.
Try running API Extractor on a large monorepo and confirm that the .d.ts rollups are generated without errors, and .api.md reports don't have diffs
Regenerate the Rush Stack API reference docs and check the diff for any regressions (@octogonz can help with this)
After merging this PR, immediately publish a release and then upgrade the Rush Stack decoupledLocalDependencies to confirm that the other half of our projects build correctly

Impacted documentation

Mainly we just need to ensure that rush change logs accurately convey the impact of projects that got upgraded. For example, is the consumer of our package forced to upgrade their TypeScript compiler?

iclanton requested review from octogonz, apostolisms, D4N14L, dmichon-msft and patmill as code owners

May 5, 2023 23:15

octogonz reviewed

View reviewed changes

apps/heft/package.json Show resolved Hide resolved

octogonz reviewed

View reviewed changes

apps/api-extractor/package.json Show resolved Hide resolved

octogonz reviewed

View reviewed changes

build-tests/install-test-workspace/workspace/typescript-v3-test/package.json Outdated Show resolved Hide resolved

octogonz reviewed

View reviewed changes

common/config/rush/pnpm-config.json Show resolved Hide resolved

octogonz reviewed

View reviewed changes

eslint/eslint-config/package.json Show resolved Hide resolved

octogonz reviewed

View reviewed changes

eslint/eslint-plugin/src/no-untyped-underscore.ts Show resolved Hide resolved

iclanton added 5 commits

May 21, 2023 20:25


          Upgrade TypeScript to ~5.0.4.

e779442


          Fix the typescript-v3-test project.

81ef205


          Introduce test projects for TSv2, TSv3, and TSv4.

0002b1c


          Include a test for 'export type *'


          Add a test for no-untyped-underscore.

49c894e

iclanton force-pushed the typescript-5 branch from 61b2f4b to 49c894e Compare

May 22, 2023 04:21

iclanton added 3 commits

May 21, 2023 21:24


          Fix some issues with copy-static-assets.json.

08cb565


          Fix some rush-project.json files.

d11004a


          Update README.

a5d39fa

octogonz approved these changes

View reviewed changes

Collaborator

octogonz left a comment

Thanks for doing this work!

iclanton merged commit c7cec89 into microsoft:main

iclanton deleted the typescript-5 branch

May 22, 2023 06:11

This was referenced May 22, 2023

Add a build test for tsconfig.json multi-extends. #4126

Open

Add a test case for --allowArbitraryExtensions. #4127

Open

Bump cyclics. #4128

Merged

octogonz mentioned this pull request

[api-extractor] Missing support for TS 4.9 satisfies operator #3890

Closed

Tanimodori mentioned this pull request

Support TypeScript 5 and other TypeScript versions qmhc/vite-plugin-dts#194

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Faithfinder Faithfinder left review comments

octogonz octogonz approved these changes

apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

D4N14L Awaiting requested review from D4N14L D4N14L is a code owner

dmichon-msft Awaiting requested review from dmichon-msft dmichon-msft is a code owner

patmill Awaiting requested review from patmill patmill is a code owner

Labels

None yet