-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Add support for pnpm ignoredOptionalDependencies #4928
[rush] Add support for pnpm ignoredOptionalDependencies #4928
Conversation
@microsoft-github-policy-service agree |
Making a draft PR for now while waiting for response on Zullipchat regarding testing changes and how to fix failing CI. |
8ff0228
to
a9e4ede
Compare
a9e4ede
to
8ef00ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glitchkyle it looks like your description mentions updating the rush init
template, but I don't see any changes relating to that. Were they missed?
I could be wrong here but I thought the Should be a quick change though by adding |
@glitchkyle yes you'll need to manually update the template. It's not updated as a part of any auto-generation process.... though that would be nice. |
Summary
Fixes #4859
Changes include updating pnpm configuration to use pnpm's
ignoredOptionalDependencies
setting. End-user should now be able to specify optional dependencies incommon/config/rush/pnpm-config.json
in case some optional dependencies are required at a later point.Details
Changes focused on updating the
rush init
template and havingignoredOptionalDependencies
incommon/temp/package.json
copied fromcommon/config/rush/pnpm-config.json
. Changes might not fully reflect until schema changes andrushVersion
are updated after merging this PR.How it was tested
rush init
(when I had the schema changed incommon/config/rush/pnpm-config.json
) to check ifcommon/config/rush/pnpm-config.json
contained newly added fieldglobalIgnoredOptionalDependencies
rush update
with local build after addingfsevents
inglobalIgnoredOptionalDependencies
to see iffsevents
was incommon/temp/package.json
Impacted documentation
PR might affect
pnpm-config.json
schema (https://rushjs.io/pages/configs/pnpm-config_json/)