Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heft] Stop using true-case-path #4969

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

dmichon-msft
Copy link
Contributor

@dmichon-msft dmichon-msft commented Oct 12, 2024

Summary

Remove usage of true-case-path in Heft.

Details

The implementation of true-case-path performs directory enumeration of every folder between the file system root and heft's working directory. Usage of this tool was motivated by issues with drive letter casing normalization on Windows, but the implementation of doing so in true-case-path is just a hardcoded "if on Windows, uppercase the drive letter", so we may as well just do the same directly.

The directory enumerations cause problems when running inside of build systems that monitor file system accesses, since they cause the system to see the process as enumerating root-level folders.

How it was tested

The pipelines for this PR cover Heft sufficiently.

Impacted documentation

None.

@dmichon-msft dmichon-msft merged commit 4b95d46 into microsoft:main Oct 21, 2024
4 checks passed
@dmichon-msft dmichon-msft deleted the kill-true-case-path branch October 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants