[api-extractor] pass compilerOptions into getModeForUsageLocation to fix TS 5.6 #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
This was referenced Oct 14, 2024
D4N14L
reviewed
Oct 14, 2024
common/changes/@microsoft/api-extractor/fix-5.6_2024-10-14-19-47.json
Outdated
Show resolved
Hide resolved
D4N14L
approved these changes
Oct 14, 2024
|
Thanks for merging this! |
|
@jakebailey just curious - is your toolchain somehow bypassing the hardwired version of TypeScript that is bundled with API Extractor? |
|
Bundled with TypeScript? Do you mean the explicit version listed in package.json? Yes, It'd be nice if api-extractor updated its version, or had a version range it supported (and then tested against TS nightly to find breaks like this...) (To be clear, it's not my toolchain...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4919
Details
getModeForUsageLocationhas required compiler options for a while, but this was hidden by anas any. Passing in the compiler options prevents the crash.How it was tested
I made the same change in
node_modulesfor typescript-eslint, and api-extractor no longer crashed.It's not clear to me how to test this otherwise without also upgrading the repo to TS 5.6.
Impacted documentation
None.