[package-extractor] Fix .bin folder extraction when using the default link creation mode
#4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D4N14L
requested review from
iclanton,
octogonz,
apostolisms and
dmichon-msft
as code owners
D4N14L
changed the title
.bin folder extraction when using the default link creation mode
iclanton
approved these changes
Oct 22, 2024
common/changes/@rushstack/package-extractor/user-danade-FixBinExtract_2024-10-22-19-21.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4961
Details
The
.binlinks were previously created after the realization of the deployed projectnode_modulesfolder. Changes in #4924 were made to centralize and simplify the handling of assets in a deployment, but did not take this requirement into account. This meant that the.binlinks were not created in the deployed project'snode_modulesfolder. This change moves creation of the.binlinks to after the creation of thenode_modulesfolder, but before the assets are finalized, which ensures that the.binlinks are created and included in the generated archive (if one was requested).How it was tested
Locally against repro provided in issue.