Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix my comments in #40 #54

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix my comments in #40 #54

wants to merge 14 commits into from

Commits on Jan 10, 2024

  1. let s = &mut String::from("hello"); -> `let mut s = String::from("h… 

    …ello");`
    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a0f5ca9 View commit details
    Browse the repository at this point in the history

  2. Box::new("") creates Box<&str>, not Box<str>. It needs to be `l… 

    …et str: Box<str> = Box::from("")`

Or `let str = Box::<str>::from("")`
    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    39b5e93 View commit details
    Browse the repository at this point in the history

  3. Note that format!() only supports bare identifiers in the string 

    There is place to expand more on the possibilities with it (e.g `{0}` or `{name}, name = `, but it can be seen in the documentation.
    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8d8e9ab View commit details
    Browse the repository at this point in the history

  4. Mention the :#? format specifier

    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    96a17ef View commit details
    Browse the repository at this point in the history

  5. Mention to_string()

    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    22fdebd View commit details
    Browse the repository at this point in the history

  6. Mention properties are rare in Rust, as opposed to in C#

    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7f46afe View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @ChayimFriedman2
    ChayimFriedman2 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4b5728d View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Mention std::ptr::eq() as the equivalence to reference equality in … 

    …Rust
    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7f39a45 View commit details
    Browse the repository at this point in the history

  2. Mention the T: Trait shortcut to where clauses

    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a68e7ff View commit details
    Browse the repository at this point in the history

  3. Mention std::error::Error isn't strictly required

    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    23e9796 View commit details
    Browse the repository at this point in the history

  4. Demonstrate how and_then() is a replacement to C#'s ? operator 

    The example is a bit complicated, but I haven't found a better one.
    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6d06e52 View commit details
    Browse the repository at this point in the history

  5. Mention the ? operator in Rust

    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    dc23171 View commit details
    Browse the repository at this point in the history

  6. Mention unwrap() and expect()

    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    11b2b01 View commit details
    Browse the repository at this point in the history

  7. Mention scoped threads

    @ChayimFriedman2
    ChayimFriedman2 committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fa0ade5 View commit details
    Browse the repository at this point in the history