Update Git to include race condition fix in gvfs-helper #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilbaker
reviewed
Oct 4, 2019
| @@ -218,7 +218,7 @@ private void LoadBlobsViaGit(ScalarFunctionalTestEnlistment enlistment) | |||
| { | |||
| // 'git rev-list --objects' will check for all objects' existence, which | |||
| // triggers an object download on every missing blob. | |||
| ProcessResult result = GitHelpers.InvokeGitAgainstScalarRepo(enlistment.RepoRoot, "rev-list --objects HEAD^{tree}"); | |||
| ProcessResult result = GitHelpers.InvokeGitAgainstScalarRepo(enlistment.RepoRoot, "rev-list --all --objects"); | |||
There was a problem hiding this comment.
Seeing the tests that rely on this method pass makes the issue in #147 all the more strange.
There was a problem hiding this comment.
Actually, I would not be surprised if most of these tests are not validating where git decides to download the objects. If the parallel read tests end up download the same objects for each repo (in .git/objects) I'm not sure that they'd fail.
That could explain why #147 is still an issue, because that test specifically validates the shared cache folder was recreated.
wilbaker
approved these changes
Oct 4, 2019
|
(I pushed the update for the Git version before the installer build is complete.) |
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156.
See microsoft/git#205 for the Git code change. One race condition still existed: who creates the loose object directory first? The simple change is to check if the directory exists after the mkdir fails.