Prefetch all files on clone #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickstolee
commented
Aug 14, 2019
wilbaker
approved these changes
Aug 14, 2019
Will disable later when doing sparse clone Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
|
/azp run microsoft.scalar |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
...adding a comment made the Mac functional tests sit forever. Ordering the tests that were not reporting logs fixed the problem... I don't even know anymore. I'll wait until morning for this one. |
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
commented
Aug 15, 2019
| @@ -180,8 +180,10 @@ private void ExpandOneTempPack(bool copyPackBackToPackDirectory) | |||
| string[] packFiles = Directory.GetFiles(this.TempPackRoot, "pack-*.pack"); | |||
| Assert.Greater(packFiles.Length, 0); | |||
|
|
|||
| // Pick the first one found | |||
| string packFile = packFiles[0]; | |||
| List<FileInfo> fileInfos = packFiles.Select(file => new FileInfo(file)) | |||
There was a problem hiding this comment.
I was able to repro the functional test hang, and it is related to unpacking the prefetch pack. To fix the problem long-term, we will want to make these tests use the sparse mode, which avoids the prefetch. Temporarily, we can select the smallest pack to turn into loose objects.
This was referenced Aug 16, 2019
Merged
derrickstolee
added a commit
that referenced
this pull request
Aug 21, 2019
Long term, we will not have a mount, so this feature will eventually be meaningless. In the meantime, it is only causing possible problems with hydrating files. Resolves #26 permanently. In a normal clone, we already resolved it in #56 by prefetching all files on clone. However, we still dynamically prefetch on a sparse clone (#54).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will disable later when doing sparse clone. This speeds up our functional tests (and any clone we do for local testing).
With the current count of functional tests, they run in 3-4 minutes instead of 5-7 minutes. As that list grows, this will be even more important.