Update _data_pipelines.py #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added update data pipeline definition method
m-kovalsky
reviewed
Dec 1, 2024
src/sempy_labs/_data_pipelines.py
Outdated
|
|
||
|
|
||
| def update_data_pipeline_definition( | ||
| name: str, pipeline_content: str, workspace: Optional[str] = None |
There was a problem hiding this comment.
won't the content be in dict format? Check out the _conv_b64 function in sempy_labs._helper_functions.
let's use the parameter' content' instead of 'pipeline_content'.
There was a problem hiding this comment.
Sure, I can change it to dict, was using your update notebook definition as a template
LMK
There was a problem hiding this comment.
ah but the content/definition for a notebook isn't in json format. it's in .py format.
There was a problem hiding this comment.
gotcha, make sense. i'll update tomorrow!
m-kovalsky
reviewed
Dec 1, 2024
Update pipeline_content to dict
Added new function to data_pipelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added update data pipeline definition method