Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip table cols not in df when schemaCheck disabled #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip table cols not in df when schemaCheck disabled #154

wants to merge 2 commits into from

Conversation

luxu1-ms
Copy link
Collaborator

@luxu1-ms luxu1-ms commented Oct 19, 2021 •
edited
Loading

This PR will skip the cols not exist in df when strictSchemaCheck disabled. This PR will enable below two use cases.

  1. Auto generated columns. These columns cannot be generated by source df. Including computed columns, temporal table(always generated), graph tables...
  2. Source df has less columns than sql table. (e.g. When SQL table has hundreds of cols while user only want to insert some of columns and all the reset columns remain null).

Test

This PR passed the CI / GCI tests. I also added test cases/ examples for computed cols, temporal table, graph table in notebook in PR #160 .

@luxu1-ms luxu1-ms force-pushed the match-df-schema branch 6 times, most recently from 539b561 to baca532 Compare October 20, 2021 22:59
@luxu1-ms luxu1-ms changed the title [WIP]Skipping table cols not in df when schemaCheck disabled Skip table cols not in df when schemaCheck disabled Oct 20, 2021
@luxu1-ms luxu1-ms requested a review from shivsood October 20, 2021 23:20
@shivsood shivsood removed their request for review November 8, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luxu1-ms