Set appname and add prefix for SQL Server session #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change also respects the case when the user passes in applicationName in the `options` Map.
shivsood
approved these changes
Nov 9, 2021
src/main/scala/com/microsoft/sqlserver/jdbc/spark/DefaultSource.scala
Outdated
Show resolved
Hide resolved
shanyu
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR set default application name of SQL Server session to "Spark MSSQL Connector", and adds prefix for user input application name. If user specify the application name "appName", the application name of SQL Server session will be "Spark MSSQL Connector appName".
df.write \ .format("com.microsoft.sqlserver.jdbc.spark") \ .mode("append") \ .option("url", url) \ .option("dbtable", dbtable) \ .option("user", user) \ .option("password", password) \ .option("applicationName", "myAPP") \ .save()The original PR to set default app name is #125 by @arvindshmicrosoft
Test
This PR pased CI, GCI tests.
Run below sql statement during data writing to get program_name (application name) and test this PR.
SELECT * FROM sys.dm_exec_sessions WHERE client_interface_name LIKE 'Microsoft JDBC Driver%'This PR got tested with BEST_EFFORT, NO_DUPLICATES, data pool.