Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix an apparent x86 miscompilation on MSVC 19.38 (#16742)
There's an apparent miscompilation of `dynamic_bitset` on x86 with MSVC 19.38, where the following code: ```cpp dynamic_bitset<uint64_t> bits(80 * 24, 0); bits.set(0, 3 * 80, true); ``` is expected to set the first 3.75 blocks to 1 which should produce the following blocks: ``` 0xffffffffffffffff 0xffffffffffffffff 0xffffffffffffffff 0x0000ffffffffffff ``` but it actually produces: ``` 0xffffffffffffffff 0x00000000ffffffff 0xffffffffffffffff 0x0000ffffffffffff ``` The weird thing here is that this only happens if `til::bitmap` uses a `dynamic_bitset<uint64_t>`. As soon as it uses `<uint32_t>` any other instantiation of `<uint64_t>` is magically fixed. Conclusion: Use `size_t` until we know what's going on. Last known good CL version: 14.37.32822 Current broken CL version: 14.38.33130 ## Validation Steps Performed The following test completes successfully again: ```cpp til::bitmap map{ { 80, 24 } }; map.translate({ 0, 3 }, true); VERIFY_ARE_EQUAL(3u, map.runs().size()); ``` (cherry picked from commit d3ec47a) Service-Card-Id: 91885583 Service-Version: 1.19
- Loading branch information
0ec73b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@check-spelling-bot Report
🔴 Please review
See the 📜action log for details.
Unrecognized words (13)
Previously acknowledged words that are now absent
DESTINATIONNAME :arrow_right:To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands
... in a clone of the git@github.com:microsoft/terminal.git repository
on the
release-1.19
branch (ℹ️ how do I use this?):Pattern suggestions ✂️ (1)
You could add these patterns to .github/actions/spelling/patterns/0ec73b1a6ec3ef0a83e58643ef7d511c096f1e4b.txt:
Warnings (1)
See the 📜action log for details.
See ℹ️ Event descriptions for more information.
✏️ Contributor please read this
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
expect.txt
and theexcludes.txt
files.If the listed items are:
.github/actions/spelling/allow/names.txt
..github/actions/spelling/allow/
..github/actions/spelling/expect/
..github/actions/spelling/patterns/
.See the
README.md
in each directory for more information.🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉
If the flagged items are 🤯 false positives
If items relate to a ...
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txt
file matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^
refers to the file's path from the root of the repository, so^README\.md$
would exclude README.md (on whichever branch you're using).well-formed pattern.
If you can write a pattern that would match it,
try adding it to the
patterns.txt
file.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.