Skip to content

Commit

Permalink
AtlasEngine: Fix a correctness bug (#13956)
Browse files Browse the repository at this point in the history
`ATLAS_POD_OPS` doesn't check for `has_unique_object_representations` and so a
bug exists where `CachedCursorOptions` comparisons invoke undefined behavior.
  • Loading branch information
lhecker authored Sep 9, 2022
1 parent c02bb29 commit 124058f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/renderer/atlas/AtlasEngine.h
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,7 @@ namespace Microsoft::Console::Render
u32 cursorColor = INVALID_COLOR;
u16 cursorType = gsl::narrow_cast<u16>(CursorType::Legacy);
u8 heightPercentage = 20;
u8 _padding = 0;

ATLAS_POD_OPS(CachedCursorOptions)
};
Expand Down

0 comments on commit 124058f

Please sign in to comment.