A few PR comments. A constexpr here, a misleading comment there, and …

…an extraneous local.
microsoft · Sep 9, 2019 · 18bacfe · 18bacfe
1 parent d8ff47a
commit 18bacfe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/buffer/out/OutputCell.cpp b/src/buffer/out/OutputCell.cpp
@@ -111,7 +111,5 @@ void OutputCell::_setFromOutputCellView(const OutputCellView& cell)
     _dbcsAttribute = cell.DbcsAttr();
     _textAttribute = cell.TextAttr();
     _behavior = cell.TextAttrBehavior();
-
-    const auto view = cell.Chars();
-    _text = view;
+    _text = cell.Chars();
 }
diff --git a/src/renderer/dx/DxRenderer.cpp b/src/renderer/dx/DxRenderer.cpp
@@ -15,7 +15,7 @@
 #pragma hdrstop
 
 static constexpr float POINTS_PER_INCH = 72.0f;
-static std::wstring_view FALLBACK_FONT_FACE = L"Consolas";
+static constexpr std::wstring_view FALLBACK_FONT_FACE = L"Consolas";
 static constexpr std::wstring_view FALLBACK_LOCALE = L"en-us";
 
 using namespace Microsoft::Console::Render;

diff --git a/src/types/convert.cpp b/src/types/convert.cpp
@@ -44,7 +44,7 @@ static const WORD leftShiftScanCode = 0x2A;
     size_t cchNeeded;
     THROW_IF_FAILED(IntToSizeT(iTarget, &cchNeeded));
 
-    // Allocate ourselves space in a smart pointer.
+    // Allocate ourselves some space
     std::wstring out;
     out.resize(cchNeeded);
 
@@ -85,7 +85,7 @@ static const WORD leftShiftScanCode = 0x2A;
     size_t cchNeeded;
     THROW_IF_FAILED(IntToSizeT(iTarget, &cchNeeded));
 
-    // Allocate ourselves space in a smart pointer
+    // Allocate ourselves some space
     std::string out;
     out.resize(cchNeeded);