Try to access current row attr only when index is in range

microsoft · Oct 1, 2019 · 1cce2ad · 1cce2ad
1 parent 4a0c7fd
commit 1cce2ad
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/buffer/out/AttrRow.cpp b/src/buffer/out/AttrRow.cpp
@@ -292,12 +292,12 @@ void ATTR_ROW::ReplaceAttrs(const TextAttribute& toBeReplacedAttr, const TextAtt
         {
             size_t lowerBound = 0;
             size_t upperBound = 0;
-            for (int i = 0; i < _list.size(); i++)
+            for (auto i = 0; i < _list.size(); i++)
             {
                 upperBound += _list[i].GetLength();
-                const auto curr = std::next(_list.begin(), i);
                 if (iStart >= lowerBound && iStart < upperBound)
                 {
+                    const auto curr = std::next(_list.begin(), i);
                     if (curr->GetAttributes() == NewAttr)
                     {
                         return S_OK;